Skip to content

Add InputDatePickerFormField.focusNode prop #136673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Oct 23, 2023
Merged

Add InputDatePickerFormField.focusNode prop #136673

auto-submit merged 3 commits into from
Oct 23, 2023

Conversation

@piedcipher
Copy link
Member

@piedcipher piedcipher commented Oct 16, 2023 •
edited
Loading

Adds focusNode prop to InputDatePickerFormField widget.

Fixes #105881

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 16, 2023
gspencergoog
gspencergoog approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Good idea, thanks for the PR!

chunhtai
chunhtai reviewed Oct 20, 2023
View reviewed changes
packages/flutter/test/material/input_date_picker_form_field_test.dart Outdated
Copy link
Contributor

@chunhtai chunhtai Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a check that the focusNode in TextFormField is the same as the one that passes in?

Copy link
Member Author

@piedcipher piedcipher Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will this test be part of TextFormField or InputDatePickerFormField?

Copy link
Member Author

@piedcipher piedcipher Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍✅, could you please check?

Copy link
Contributor

@chunhtai chunhtai Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

chunhtai
chunhtai approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/test/material/input_date_picker_form_field_test.dart Outdated
Copy link
Contributor

@chunhtai chunhtai Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 23, 2023
@auto-submit auto-submit bot merged commit 2de1af4 into flutter:master Oct 23, 2023
@piedcipher piedcipher deleted the feature/focus_node_idpff branch October 23, 2023 17:19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023
@engine-flutter-autoroll
2de1af4 Add InputDatePickerFormField.focusNode prop (flutter/flutte…
ee1e8b5 
…r#136673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023
@engine-flutter-autoroll
2de1af4 Add InputDatePickerFormField.focusNode prop (flutter/flutte…
9c0af7e 
…r#136673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023
@engine-flutter-autoroll
2de1af4 Add InputDatePickerFormField.focusNode prop (flutter/flutte…
24139ee 
…r#136673)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
2de1af4 Add InputDatePickerFormField.focusNode prop (flutter/flutte…
0b5d24e 
…r#136673)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
2de1af4 Add InputDatePickerFormField.focusNode prop (flutter/flutte…
8cdcf9b 
…r#136673)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
2de1af4 Add InputDatePickerFormField.focusNode prop (flutter/flutte…
f75df56 
…r#136673)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
2de1af4 Add InputDatePickerFormField.focusNode prop (flutter/flutte…
2cc78c9 
…r#136673)
@HansMuller HansMuller mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Proposal] Add FocusNode to InputDatePickerFormField

3 participants

@piedcipher @gspencergoog @chunhtai