Update BottomNavigationBar tests for M3 #136624

bleroux · 2023-10-16T07:24:42Z

This PR updates BottomNavigationBar unit tests for M3 migration.

More info in #127064

It was somewhat complex because existing tests relied on a lot of magic numbers.

flutter-dashboard · 2023-10-16T09:33:13Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #136624 at sha ef360ed6c581b2d40080606bd93c07aa4930fc8e

HansMuller

LGTM

flutter-dashboard · 2023-10-19T08:34:28Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #136624 at sha fe67729ed84cb61e18c2ce4ecbda082f61d23b2a

Piinks · 2023-11-03T17:46:53Z

packages/flutter/test/material/bottom_navigation_bar_test.dart

Nit: Looks like some extra commented out code

Suggested change

final double secondItemLeft = itemFullWith + itemFullWith / 2 - secondItemContentWidth / 2; //const double firstLabelCenter = firstItemLeft + itemWidth / 2; // 250

final double secondItemLeft = itemFullWith + itemFullWith / 2 - secondItemContentWidth / 2;

Oh I was hoping I could commit this, but it appears the PR does not have permissions enabled for me to edit it. Pushing a new commit (not force pushing, and not rebasing) would fix the Gold issue here as well.

Good catch for the extra comment! 👍

(not force pushing, and not rebasing)

Thanks for your help.
I tried doing so but there were several tests failures (this PR was far from the tip of the tree, the failures were related to some changes on the CI configuration on Mac).

Let see how it goes after the rebase, I will try to use my new Gold tool knowledge 😄 and I will ask for your help if the PR is still stuck.

flutter-dashboard · 2023-11-06T08:23:24Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #136624 at sha 501261f

flutter-dashboard · 2023-11-06T10:05:27Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #136624 at sha f8def8f

flutter-dashboard · 2023-11-06T13:35:26Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #136624 at sha d7ce91a

flutter-dashboard · 2023-11-06T14:41:48Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #136624 at sha 9b6a8b4

This reverts commit 59d4d76.

HansMuller · 2023-11-06T16:43:16Z

@bleroux - I'm reverting this PR because the build is currently red due to Skia Gold received an unapproved image in post-submit errors. For example:

01:16 +2402 ~4: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/bottom_navigation_bar_test.dart: Material3 - BottomNavigationBar shifting backgroundColor with transition pump 5
0.1s
 ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
0.1s
 The following SkiaException was thrown while running async test code:
0.1s
 Skia Gold received an unapproved image in post-submit
0.1s
 testing. Golden file images in flutter/flutter are triaged
0.1s
 in pre-submit during code review for the given PR.

Reverts #136624 Initiated by: HansMuller This change reverts the following previous change: Original Description: This PR updates `BottomNavigationBar` unit tests for M3 migration. More info in #127064 It was somewhat complex because existing tests relied on a lot of magic numbers.

HansMuller · 2023-11-06T16:46:40Z

@bleroux , @Piinks - I'm not sure what's going wrong here, the links from Gold, like #136624 (comment), don't appear to contain any diffs?

Piinks · 2023-11-06T17:17:43Z

The images were waiting to be approved at https://flutter-gold.skia.org/
For future gardening, please check there first. The image can be approved and the test can be rerun to fix the tree.

Roll Flutter from 29b2516 to f5a9835 (101 revisions) flutter/flutter@29b2516...f5a9835 2023-11-06 [email protected] Check sample links for malformed links (flutter/flutter#137807) 2023-11-06 [email protected] Change cast in json parsing (flutter/flutter#137708) 2023-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update BottomNavigationBar tests for M3" (flutter/flutter#137948) 2023-11-06 [email protected] Roll Packages from cccf5d2 to 49eac1f (2 revisions) (flutter/flutter#137943) 2023-11-06 [email protected] Update BottomNavigationBar tests for M3 (flutter/flutter#136624) 2023-11-06 [email protected] Roll Flutter Engine from 4f6ed31bd8bd to bdfa8aa8f81f (1 revision) (flutter/flutter#137941) 2023-11-06 [email protected] Roll Flutter Engine from b9b3269b0b2c to 4f6ed31bd8bd (2 revisions) (flutter/flutter#137935) 2023-11-06 [email protected] Provide a helpful error message when `ColorScheme.brightness` doesn't match `ThemeData.brightness` (flutter/flutter#137611) 2023-11-06 [email protected] Roll Flutter Engine from 555ffa17b55c to b9b3269b0b2c (1 revision) (flutter/flutter#137933) 2023-11-06 [email protected] Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (flutter/flutter#137837) 2023-11-06 [email protected] Roll Flutter Engine from 0d8c7ceacc01 to 555ffa17b55c (1 revision) (flutter/flutter#137921) 2023-11-06 [email protected] Roll Flutter Engine from 11d66db97d3f to 0d8c7ceacc01 (1 revision) (flutter/flutter#137920) 2023-11-05 [email protected] Roll Flutter Engine from a7592e42464c to 11d66db97d3f (1 revision) (flutter/flutter#137914) 2023-11-05 [email protected] Roll Flutter Engine from 1c6bd97e2288 to a7592e42464c (1 revision) (flutter/flutter#137912) 2023-11-05 [email protected] Roll Flutter Engine from daf18fe46b72 to 1c6bd97e2288 (1 revision) (flutter/flutter#137908) 2023-11-04 [email protected] Roll Flutter Engine from a45e679828e6 to daf18fe46b72 (1 revision) (flutter/flutter#137904) 2023-11-04 [email protected] Roll Flutter Engine from fb2a9c20141e to a45e679828e6 (1 revision) (flutter/flutter#137903) 2023-11-04 [email protected] Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) (flutter/flutter#137900) 2023-11-04 [email protected] Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) (flutter/flutter#137898) 2023-11-04 [email protected] Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) (flutter/flutter#137892) 2023-11-04 [email protected] Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) (flutter/flutter#137887) 2023-11-04 [email protected] HeroController should dispatch creation and disposal events. (flutter/flutter#137835) 2023-11-04 [email protected] Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) (flutter/flutter#137877) 2023-11-03 [email protected] InheritedElement.removeDependent() (flutter/flutter#129210) 2023-11-03 [email protected] Remove unused generic type from BottomSheet (flutter/flutter#137791) 2023-11-03 [email protected] Roll Flutter Engine from 035740c1f90e to ec20731de6ff (2 revisions) (flutter/flutter#137872) 2023-11-03 [email protected] Pin dart-lang/native dependencies (flutter/flutter#137601) 2023-11-03 [email protected] Send caret rect to embedder on selection update (flutter/flutter#137863) 2023-11-03 [email protected] Roll Flutter Engine from 677040f10f65 to 035740c1f90e (4 revisions) (flutter/flutter#137871) 2023-11-03 [email protected] Tooltip docs: Recommend setting preferBelow to false in theme (flutter/flutter#135879) 2023-11-03 [email protected] Roll Flutter Engine from f363a6e5e093 to 677040f10f65 (2 revisions) (flutter/flutter#137861) 2023-11-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Support Android 34" (flutter/flutter#137865) 2023-11-03 [email protected] InkFeature should dispatch creation and disposal events. (flutter/flutter#137793) 2023-11-03 [email protected] AppLifecycleListener should dispatch creation and disposal events. (flutter/flutter#137840) 2023-11-03 [email protected] Roll Flutter Engine from d5ccb5b1b706 to f363a6e5e093 (2 revisions) (flutter/flutter#137858) 2023-11-03 [email protected] Roll Flutter Engine from 72262a238090 to d5ccb5b1b706 (3 revisions) (flutter/flutter#137857) 2023-11-03 [email protected] Updated the nested navigation NavigationBar example (flutter/flutter#137788) 2023-11-03 [email protected] Roll Flutter Engine from 0415a4f5e2a2 to 72262a238090 (2 revisions) (flutter/flutter#137853) 2023-11-03 [email protected] Roll Flutter Engine from 8531c5935356 to 0415a4f5e2a2 (1 revision) (flutter/flutter#137847) 2023-11-03 [email protected] Roll flutter gallery version forward. (flutter/flutter#137846) 2023-11-03 [email protected] Roll Flutter Engine from 43653c5a3ec8 to 8531c5935356 (1 revision) (flutter/flutter#137845) 2023-11-03 [email protected] Roll Packages from 33c2b4e to cccf5d2 (6 revisions) (flutter/flutter#137841) 2023-11-03 [email protected] [web] dispatch corresponding keyup events in text editing integrations (flutter/flutter#136874) 2023-11-03 [email protected] [leak-tracking] Add more leak tracking in test/painting #3 (flutter/flutter#136170) 2023-11-03 [email protected] Upgrade leak_tracker and remove some deps in allow list. (flutter/flutter#137806) 2023-11-03 [email protected] Roll Flutter Engine from fc7c3f70c076 to 43653c5a3ec8 (1 revision) (flutter/flutter#137827) ...

This is a reland of #136624 which was reverted because one new M3 golden test failed. The failure was related to the ink sparkle animation. Ink sparkle is the M3 default animation, it does not play well with golden because it introduces an element of randomness. One way to avoid this randomness is to use the `InkSparkle.constantTurbulenceSeedSplashFactory`. This PR has two commits: - the first one is the original PR (#136624). - the second one updates the failing test using `InkSparkle.constantTurbulenceSeedSplashFactory`.

Roll Flutter from 29b25165cab8 to f5a983535131 (101 revisions) flutter/flutter@29b2516...f5a9835 2023-11-06 [email protected] Check sample links for malformed links (flutter/flutter#137807) 2023-11-06 [email protected] Change cast in json parsing (flutter/flutter#137708) 2023-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update BottomNavigationBar tests for M3" (flutter/flutter#137948) 2023-11-06 [email protected] Roll Packages from cccf5d24d703 to 49eac1fec6c7 (2 revisions) (flutter/flutter#137943) 2023-11-06 [email protected] Update BottomNavigationBar tests for M3 (flutter/flutter#136624) 2023-11-06 [email protected] Roll Flutter Engine from 4f6ed31bd8bd to bdfa8aa8f81f (1 revision) (flutter/flutter#137941) 2023-11-06 [email protected] Roll Flutter Engine from b9b3269b0b2c to 4f6ed31bd8bd (2 revisions) (flutter/flutter#137935) 2023-11-06 [email protected] Provide a helpful error message when `ColorScheme.brightness` doesn't match `ThemeData.brightness` (flutter/flutter#137611) 2023-11-06 [email protected] Roll Flutter Engine from 555ffa17b55c to b9b3269b0b2c (1 revision) (flutter/flutter#137933) 2023-11-06 [email protected] Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (flutter/flutter#137837) 2023-11-06 [email protected] Roll Flutter Engine from 0d8c7ceacc01 to 555ffa17b55c (1 revision) (flutter/flutter#137921) 2023-11-06 [email protected] Roll Flutter Engine from 11d66db97d3f to 0d8c7ceacc01 (1 revision) (flutter/flutter#137920) 2023-11-05 [email protected] Roll Flutter Engine from a7592e42464c to 11d66db97d3f (1 revision) (flutter/flutter#137914) 2023-11-05 [email protected] Roll Flutter Engine from 1c6bd97e2288 to a7592e42464c (1 revision) (flutter/flutter#137912) 2023-11-05 [email protected] Roll Flutter Engine from daf18fe46b72 to 1c6bd97e2288 (1 revision) (flutter/flutter#137908) 2023-11-04 [email protected] Roll Flutter Engine from a45e679828e6 to daf18fe46b72 (1 revision) (flutter/flutter#137904) 2023-11-04 [email protected] Roll Flutter Engine from fb2a9c20141e to a45e679828e6 (1 revision) (flutter/flutter#137903) 2023-11-04 [email protected] Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) (flutter/flutter#137900) 2023-11-04 [email protected] Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) (flutter/flutter#137898) 2023-11-04 [email protected] Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) (flutter/flutter#137892) 2023-11-04 [email protected] Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) (flutter/flutter#137887) 2023-11-04 [email protected] HeroController should dispatch creation and disposal events. (flutter/flutter#137835) 2023-11-04 [email protected] Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) (flutter/flutter#137877) 2023-11-03 [email protected] InheritedElement.removeDependent() (flutter/flutter#129210) 2023-11-03 [email protected] Remove unused generic type from BottomSheet (flutter/flutter#137791) 2023-11-03 [email protected] Roll Flutter Engine from 035740c1f90e to ec20731de6ff (2 revisions) (flutter/flutter#137872) 2023-11-03 [email protected] Pin dart-lang/native dependencies (flutter/flutter#137601) 2023-11-03 [email protected] Send caret rect to embedder on selection update (flutter/flutter#137863) 2023-11-03 [email protected] Roll Flutter Engine from 677040f10f65 to 035740c1f90e (4 revisions) (flutter/flutter#137871) 2023-11-03 [email protected] Tooltip docs: Recommend setting preferBelow to false in theme (flutter/flutter#135879) 2023-11-03 [email protected] Roll Flutter Engine from f363a6e5e093 to 677040f10f65 (2 revisions) (flutter/flutter#137861) 2023-11-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Support Android 34" (flutter/flutter#137865) 2023-11-03 [email protected] InkFeature should dispatch creation and disposal events. (flutter/flutter#137793) 2023-11-03 [email protected] AppLifecycleListener should dispatch creation and disposal events. (flutter/flutter#137840) 2023-11-03 [email protected] Roll Flutter Engine from d5ccb5b1b706 to f363a6e5e093 (2 revisions) (flutter/flutter#137858) 2023-11-03 [email protected] Roll Flutter Engine from 72262a238090 to d5ccb5b1b706 (3 revisions) (flutter/flutter#137857) 2023-11-03 [email protected] Updated the nested navigation NavigationBar example (flutter/flutter#137788) 2023-11-03 [email protected] Roll Flutter Engine from 0415a4f5e2a2 to 72262a238090 (2 revisions) (flutter/flutter#137853) 2023-11-03 [email protected] Roll Flutter Engine from 8531c5935356 to 0415a4f5e2a2 (1 revision) (flutter/flutter#137847) 2023-11-03 [email protected] Roll flutter gallery version forward. (flutter/flutter#137846) 2023-11-03 [email protected] Roll Flutter Engine from 43653c5a3ec8 to 8531c5935356 (1 revision) (flutter/flutter#137845) 2023-11-03 [email protected] Roll Packages from 33c2b4e53ad7 to cccf5d24d703 (6 revisions) (flutter/flutter#137841) 2023-11-03 [email protected] [web] dispatch corresponding keyup events in text editing integrations (flutter/flutter#136874) 2023-11-03 [email protected] [leak-tracking] Add more leak tracking in test/painting #3 (flutter/flutter#136170) 2023-11-03 [email protected] Upgrade leak_tracker and remove some deps in allow list. (flutter/flutter#137806) 2023-11-03 [email protected] Roll Flutter Engine from fc7c3f70c076 to 43653c5a3ec8 (1 revision) (flutter/flutter#137827) ...

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 16, 2023

bleroux force-pushed the update_bottom_navigation_bar_test_for_M3 branch from e9d0a7d to ef360ed Compare October 16, 2023 09:03

flutter-dashboard bot added the will affect goldens Changes to golden files label Oct 16, 2023

bleroux requested a review from HansMuller October 16, 2023 12:18

HansMuller approved these changes Oct 16, 2023

View reviewed changes

bleroux force-pushed the update_bottom_navigation_bar_test_for_M3 branch from ef360ed to fe67729 Compare October 19, 2023 08:04

Piinks reviewed Nov 3, 2023

View reviewed changes

Update BottomNavigationBar tests for M3

501261f

bleroux force-pushed the update_bottom_navigation_bar_test_for_M3 branch from 8c76723 to 501261f Compare November 6, 2023 07:48

Remove leftover comment

f8def8f

Empty commit to trigger gold test

d7ce91a

Empty commit to trigger gold test

9b6a8b4

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 6, 2023

auto-submit bot merged commit 59d4d76 into flutter:master Nov 6, 2023

bleroux deleted the update_bottom_navigation_bar_test_for_M3 branch November 6, 2023 15:19

engine-flutter-autoroll mentioned this pull request Nov 6, 2023

Roll Flutter from 29b25165cab8 to 59d4d7670569 (97 revisions) flutter/packages#5337

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

59d4d76 Update BottomNavigationBar tests for M3 (flutter/flutter#136624)

b995ad9

engine-flutter-autoroll mentioned this pull request Nov 6, 2023

Roll Flutter from 29b25165cab8 to 1d66b364d1bf (98 revisions) flutter/packages#5338

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

59d4d76 Update BottomNavigationBar tests for M3 (flutter/flutter#136624)

e74424f

TahaTesser restored the update_bottom_navigation_bar_test_for_M3 branch November 6, 2023 15:58

HansMuller added the revert Autorevert PR (with "Reason for revert:" comment) label Nov 6, 2023

auto-submit bot mentioned this pull request Nov 6, 2023

Reverts "Update BottomNavigationBar tests for M3" #137948

Merged

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Nov 6, 2023

auto-submit bot pushed a commit that referenced this pull request Nov 6, 2023

Revert "Update BottomNavigationBar tests for M3 (#136624)"

2ae6123

This reverts commit 59d4d76.

engine-flutter-autoroll mentioned this pull request Nov 6, 2023

Roll Flutter from 29b25165cab8 to 3649deb3f66c (99 revisions) flutter/packages#5339

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

59d4d76 Update BottomNavigationBar tests for M3 (flutter/flutter#136624)

b9cdf48

engine-flutter-autoroll mentioned this pull request Nov 6, 2023

Roll Flutter from 29b25165cab8 to defa4bce0a0d (100 revisions) flutter/packages#5340

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

59d4d76 Update BottomNavigationBar tests for M3 (flutter/flutter#136624)

b339ca8

engine-flutter-autoroll mentioned this pull request Nov 6, 2023

Roll Flutter from 29b25165cab8 to f5a983535131 (101 revisions) flutter/packages#5341

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

59d4d76 Update BottomNavigationBar tests for M3 (flutter/flutter#136624)

d027c80

bleroux deleted the update_bottom_navigation_bar_test_for_M3 branch November 7, 2023 07:25

bleroux mentioned this pull request Nov 7, 2023

Reland update bottom navigation bar test for m3 #137998

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

59d4d76 Update BottomNavigationBar tests for M3 (flutter/flutter#136624)

73502f6

	final double secondItemLeft = itemFullWith + itemFullWith / 2 - secondItemContentWidth / 2; //const double firstLabelCenter = firstItemLeft + itemWidth / 2; // 250
	final double secondItemLeft = itemFullWith + itemFullWith / 2 - secondItemContentWidth / 2;

Update BottomNavigationBar tests for M3 #136624

Update BottomNavigationBar tests for M3 #136624

Uh oh!

Conversation

bleroux commented Oct 16, 2023

Uh oh!

flutter-dashboard bot commented Oct 16, 2023

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Oct 19, 2023

Uh oh!

Piinks Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

bleroux Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Nov 6, 2023

Uh oh!

flutter-dashboard bot commented Nov 6, 2023

Uh oh!

flutter-dashboard bot commented Nov 6, 2023

Uh oh!

flutter-dashboard bot commented Nov 6, 2023

Uh oh!

HansMuller commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HansMuller commented Nov 6, 2023

Uh oh!

Piinks commented Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Piinks Nov 3, 2023 •

edited

Loading

bleroux Nov 6, 2023 •

edited

Loading

HansMuller commented Nov 6, 2023 •

edited

Loading