Skip to content

Conversation

@vashworth
Copy link
Contributor

We renamed a few tests and therefore had to run them in bringup first (#136463). This removes bringup and moves some of them back to presubmit. Also, reorganize TESTOWNERS since they're running on hostonly now.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth marked this pull request as ready for review October 13, 2023 14:38
@vashworth
Copy link
Contributor Author

Each test has passed in bringup at least twice. Most of them have passed a bunch of times, except Mac_arm64 run_release_test_macos has only run twice and I manually triggered at least one time - I filed an issue about that (#136499).

@vashworth vashworth requested a review from zanderso October 13, 2023 15:25
@CaseyHillers CaseyHillers merged commit 9c791f4 into flutter:master Oct 13, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 15, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 15, 2023
Roll Flutter from 3865e49 to b00216b (34 revisions)

flutter/flutter@3865e49...b00216b

2023-10-15 [email protected] Roll Flutter Engine from e2319935d8c8 to f8eb68b115f1 (1 revision) (flutter/flutter#136605)
2023-10-15 [email protected] Roll Flutter Engine from edf688d30ae3 to e2319935d8c8 (1 revision) (flutter/flutter#136604)
2023-10-15 [email protected] Roll Flutter Engine from 1b3bf985490c to edf688d30ae3 (1 revision) (flutter/flutter#136603)
2023-10-15 [email protected] Roll Flutter Engine from e4f8b2267906 to 1b3bf985490c (1 revision) (flutter/flutter#136601)
2023-10-15 [email protected] Roll Flutter Engine from b64ebc0be62d to e4f8b2267906 (1 revision) (flutter/flutter#136599)
2023-10-15 [email protected] Roll Flutter Engine from 529eb423604c to b64ebc0be62d (1 revision) (flutter/flutter#136592)
2023-10-14 [email protected] Roll Flutter Engine from 82596277bd2b to 529eb423604c (1 revision) (flutter/flutter#136591)
2023-10-14 [email protected] Roll Flutter Engine from 015e352a174e to 82596277bd2b (1 revision) (flutter/flutter#136590)
2023-10-14 [email protected] Roll Flutter Engine from 73acf62a2fe1 to 015e352a174e (1 revision) (flutter/flutter#136589)
2023-10-14 [email protected] Upload GPU frame times for Impeller on Android/iOS. (flutter/flutter#136565)
2023-10-14 [email protected] Roll Flutter Engine from c777aae5ca15 to 73acf62a2fe1 (1 revision) (flutter/flutter#136581)
2023-10-14 [email protected] Roll Flutter Engine from d4e765fbefb8 to c777aae5ca15 (1 revision) (flutter/flutter#136580)
2023-10-14 [email protected] Roll Flutter Engine from 472be42e90e0 to d4e765fbefb8 (1 revision) (flutter/flutter#136578)
2023-10-14 [email protected] Roll Flutter Engine from 9149a427ef98 to 472be42e90e0 (1 revision) (flutter/flutter#136574)
2023-10-14 [email protected] _RouterState should dispose created _RestorableRouteInformation. (flutter/flutter#136556)
2023-10-14 [email protected] Roll Flutter Engine from cd1a5ed6f961 to 9149a427ef98 (1 revision) (flutter/flutter#136571)
2023-10-14 [email protected] increase windows build test sharding, revert timeout 30 mins (flutter/flutter#136474)
2023-10-14 [email protected] Roll Flutter Engine from a4e62581525c to cd1a5ed6f961 (2 revisions) (flutter/flutter#136566)
2023-10-14 [email protected] Change some usage of RawKeyEvent to KeyEvent in preparation for deprecation (flutter/flutter#136420)
2023-10-13 [email protected] Manual roll Flutter Engine from 6605151b4d0a to a4e62581525c (9 revisions) (flutter/flutter#136564)
2023-10-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.0 to 2.22.3 (flutter/flutter#136563)
2023-10-13 [email protected] [Impeller] GPU frame timings summarization. (flutter/flutter#136408)
2023-10-13 [email protected] Changes WidgetInspector to use valuenotifier instead of a force rebuild for (flutter/flutter#131634)
2023-10-13 [email protected] Roll Flutter Engine from 799e8de11c12 to 6605151b4d0a (3 revisions) (flutter/flutter#136558)
2023-10-13 [email protected] Roll Flutter Engine from 93f02f7237db to 799e8de11c12 (6 revisions) (flutter/flutter#136553)
2023-10-13 [email protected] Mark leak in NativeCodec.getNextFrame. (flutter/flutter#136514)
2023-10-13 [email protected] Stop skipping leaks in the test.  (flutter/flutter#136512)
2023-10-13 [email protected] run tests under dev/tools as part of framework-misc and get them passing (flutter/flutter#136501)
2023-10-13 [email protected] Roll Flutter Engine from 60968c892649 to 93f02f7237db (5 revisions) (flutter/flutter#136546)
2023-10-13 [email protected] Remove bringup from tests and move some back to presubmit. Reorganize TESTOWNERS. (flutter/flutter#136498)
2023-10-13 [email protected] [leak-tracking] Add leak tracking in test/rendering -2 (flutter/flutter#136310)
2023-10-13 [email protected] [leak-tracking] Add leak tracking in test/rendering -3 (flutter/flutter#136308)
2023-10-13 [email protected] Roll Packages from 93c3f69 to fd84e65 (3 revisions) (flutter/flutter#136538)
2023-10-13 [email protected] Roll Flutter Engine from f9aed0267352 to 60968c892649 (1 revision) (flutter/flutter#136539)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants