update analytics in generate api docs site to use new UA4 #136497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherfujino
force-pushed
the
update-api-docs-analytics
branch
from
f77a1d7 to
2b7268f
Compare
| @@ -0,0 +1,4 @@ | |||
| <!-- Google Tag Manager (noscript) --> | |||
Contributor
Author
There was a problem hiding this comment.
@jayoung-lee can you verify this looks right
Contributor
There was a problem hiding this comment.
This code is supposed to appear immediately after the opening tag. Is this file (analytics-footer.html) for the body?
The code itself looks correct!
Contributor
Author
There was a problem hiding this comment.
So this will put it near the end of the body. However, looking at this, this is the fallback code specifically for environments where there is no JavaScript enabled, which seems like an edge case.
To truly inject this at the beginning of the body would likely require more engineering work, and providing a new flag upstream in the dartdoc tool, rolling that to the framework, and then using it here. What do you think?
gspencergoog
approved these changes
Oct 16, 2023
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Looks good from my perspective.
christopherfujino
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 17, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 17, 2023
flutter/flutter@afc3916...6eea6e2 2023-10-17 [email protected] Removed TBD translations for optional remainingTextFieldCharacterCounZero message (flutter/flutter#136684) 2023-10-17 [email protected] Roll Flutter Engine from 86f685c87e06 to 0a4d8b99a95b (2 revisions) (flutter/flutter#136727) 2023-10-17 [email protected] Roll Flutter Engine from 793fb7d85690 to 86f685c87e06 (1 revision) (flutter/flutter#136725) 2023-10-17 [email protected] Roll Packages from 872d6d2 to d439062 (4 revisions) (flutter/flutter#136724) 2023-10-17 [email protected] Roll Flutter Engine from 9c744ad5433a to 793fb7d85690 (1 revision) (flutter/flutter#136721) 2023-10-17 [email protected] Roll Flutter Engine from 7d47532bb56f to 9c744ad5433a (1 revision) (flutter/flutter#136719) 2023-10-17 [email protected] Roll Flutter Engine from ace31a8eaea4 to 7d47532bb56f (1 revision) (flutter/flutter#136717) 2023-10-17 [email protected] Roll Flutter Engine from 077494a09872 to ace31a8eaea4 (1 revision) (flutter/flutter#136713) 2023-10-17 [email protected] Roll Flutter Engine from 8be0b5398d41 to 077494a09872 (1 revision) (flutter/flutter#136712) 2023-10-17 [email protected] Roll Flutter Engine from 90bbe8ee4ac3 to 8be0b5398d41 (1 revision) (flutter/flutter#136705) 2023-10-17 [email protected] Roll Flutter Engine from 6855e78a1aac to 90bbe8ee4ac3 (1 revision) (flutter/flutter#136700) 2023-10-17 [email protected] Roll Flutter Engine from 2159fdb8461d to 6855e78a1aac (1 revision) (flutter/flutter#136697) 2023-10-17 [email protected] Roll Flutter Engine from 2d55e29dfa79 to 2159fdb8461d (8 revisions) (flutter/flutter#136695) 2023-10-17 [email protected] Add docs to SchedulerBinding (flutter/flutter#136433) 2023-10-16 [email protected] Roll Flutter Engine from 83224dcd662e to 2d55e29dfa79 (3 revisions) (flutter/flutter#136675) 2023-10-16 [email protected] Roll Flutter Engine from c24f30343cf6 to 83224dcd662e (1 revision) (flutter/flutter#136671) 2023-10-16 [email protected] Do not hold on to stale canvas reference in _RenderSegmentedButton (flutter/flutter#136658) 2023-10-16 [email protected] Avoid use of Platform.script in isolates_test.dart (flutter/flutter#136669) 2023-10-16 [email protected] Roll Flutter Engine from ca8cf6bc256d to c24f30343cf6 (3 revisions) (flutter/flutter#136665) 2023-10-16 [email protected] update analytics in generate api docs site to use new UA4 (flutter/flutter#136497) 2023-10-16 [email protected] Roll Flutter Engine from 64734a266683 to ca8cf6bc256d (2 revisions) (flutter/flutter#136662) 2023-10-16 [email protected] Roll Flutter Engine from 850de4ce0e75 to 64734a266683 (2 revisions) (flutter/flutter#136659) 2023-10-16 [email protected] Fix prefer_mixin TODOs (flutter/flutter#136480) 2023-10-16 [email protected] Cupertino search field test leak tracking and Fix. RestorableTextEditingController not disposed. (flutter/flutter#136615) 2023-10-16 [email protected] Roll Flutter Engine from 6cc678c528d1 to 850de4ce0e75 (1 revision) (flutter/flutter#136650) 2023-10-16 [email protected] Roll Flutter Engine from 505c720fd10f to 6cc678c528d1 (1 revision) (flutter/flutter#136646) 2023-10-16 [email protected] Roll Packages from fd84e65 to 872d6d2 (5 revisions) (flutter/flutter#136644) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
christopherfujino
added a commit
to chris-forks/flutter
that referenced
this pull request
Oct 17, 2023
…6497) Change the analytics instance that the generated api.flutter.dev and master-api.flutter.dev use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the analytics instance that the generated api.flutter.dev and master-api.flutter.dev use.