-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fix NavigationRail's indicator inkwell doesn't support transparent color.
#136359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 1 commit into
flutter:master
from
TahaTesser:fix_navigation_rail_indicator_ink_transparent
Oct 16, 2023
Merged
Fix NavigationRail's indicator inkwell doesn't support transparent color.
#136359
auto-submit
merged 1 commit into
flutter:master
from
TahaTesser:fix_navigation_rail_indicator_ink_transparent
Oct 16, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansMuller
approved these changes
Oct 13, 2023
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aaaf700 to
c661de6
Compare
Contributor
|
auto label is removed for flutter/flutter/136359, due to - The status or check suite Linux android views has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 16, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 16, 2023
flutter/flutter@b00216b...afc3916 2023-10-16 [email protected] Roll Flutter Engine from cfff75967b06 to 505c720fd10f (1 revision) (flutter/flutter#136636) 2023-10-16 [email protected] Roll Flutter Engine from bd038d688ed3 to cfff75967b06 (1 revision) (flutter/flutter#136635) 2023-10-16 [email protected] Roll Flutter Engine from 15dee700867b to bd038d688ed3 (1 revision) (flutter/flutter#136626) 2023-10-16 [email protected] Roll Flutter Engine from 41b3b4f90cd9 to 15dee700867b (1 revision) (flutter/flutter#136625) 2023-10-16 [email protected] Fix `NavigationRail`'s indicator inkwell doesn't support transparent color. (flutter/flutter#136359) 2023-10-16 [email protected] Roll Flutter Engine from 12122eac2820 to 41b3b4f90cd9 (1 revision) (flutter/flutter#136623) 2023-10-16 [email protected] Roll Flutter Engine from 539ad5b232a6 to 12122eac2820 (2 revisions) (flutter/flutter#136619) 2023-10-16 [email protected] Roll Flutter Engine from 452e75f2a6b6 to 539ad5b232a6 (1 revision) (flutter/flutter#136617) 2023-10-16 [email protected] Roll Flutter Engine from 72598229bec9 to 452e75f2a6b6 (1 revision) (flutter/flutter#136614) 2023-10-15 [email protected] Roll Flutter Engine from f8eb68b115f1 to 72598229bec9 (2 revisions) (flutter/flutter#136611) 2023-10-15 [email protected] Test cover cupertino for memory leaks and fix Opacity Layer not disposed. (flutter/flutter#136576) 2023-10-15 [email protected] Test cover cupertino for memory leaks tracking -2 (flutter/flutter#136577) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

fixes NavigationRail can't have a transparent Hover color because there is always opacity set
Code sample
expand to view the code sample
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.