Skip to content

Relaxed a test on Paint.toString() to ignore dither: .... #136302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matanlurey merged 1 commit into from
Oct 11, 2023
Merged

Relaxed a test on Paint.toString() to ignore dither: .... #136302

matanlurey merged 1 commit into from
Oct 11, 2023

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Oct 11, 2023

Work towards #112498.

Behaviorally the same, except doesn't care if dither: ... shows up, or not (it won't when #112498 is fixed).

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Oct 11, 2023
jonahwilliams
jonahwilliams approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2023
@matanlurey matanlurey merged commit f38244f into flutter:master Oct 11, 2023
@matanlurey matanlurey deleted the forward-proof-dither-deprecation branch October 11, 2023 00:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
4f7666f 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
f089414 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
398703c 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
b27d398 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
47c283a 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
206936b 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
89aa708 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
e141dec 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
68feece 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
50cc2b8 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
334de39 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
2bfe908 
…flutter/flutter#136302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
bcb00b8 
…flutter/flutter#136302)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
f38244f Relaxed a test on Paint.toString() to ignore dither: .... (…
992bb1e 
…flutter/flutter#136302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matanlurey @jonahwilliams