Skip to content

[flutter_tools] catch StdinException when setting terminal to SingleCharMode #136283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Oct 10, 2023
Merged

[flutter_tools] catch StdinException when setting terminal to SingleCharMode #136283

auto-submit merged 1 commit into from
Oct 10, 2023

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Oct 10, 2023

Fixes #129198

@christopherfujino christopherfujino changed the title catch StdinException when setting terminal to SingleCharMode [flutter_tools] catch StdinException when setting terminal to SingleCharMode Oct 10, 2023
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 10, 2023
andrewkolos
andrewkolos approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2023
@auto-submit auto-submit bot merged commit b416473 into flutter:master Oct 10, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
ede4f5a 
… SingleCharMode (flutter/flutter#136283)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
a42f443 
… SingleCharMode (flutter/flutter#136283)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
f86d2bb 
… SingleCharMode (flutter/flutter#136283)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
5c764ae 
… SingleCharMode (flutter/flutter#136283)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
35f01eb 
… SingleCharMode (flutter/flutter#136283)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
74fa99c 
… SingleCharMode (flutter/flutter#136283)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
b1210c8 
… SingleCharMode (flutter/flutter#136283)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
e22ce53 
… SingleCharMode (flutter/flutter#136283)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
6382b0b 
… SingleCharMode (flutter/flutter#136283)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
f14cbae 
… SingleCharMode (flutter/flutter#136283)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
a32fc1f 
… SingleCharMode (flutter/flutter#136283)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
9b0730a 
… SingleCharMode (flutter/flutter#136283)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
ed84a1c 
… SingleCharMode (flutter/flutter#136283)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
b416473 [flutter_tools] catch StdinException when setting terminal to…
ba00291 
… SingleCharMode (flutter/flutter#136283)
christopherfujino added a commit to chris-forks/flutter that referenced this pull request Nov 7, 2023
@christopherfujino
[flutter_tools] catch StdinException when setting terminal to SingleC…
4fd303c 
…harMode (flutter#136283)

Fixes flutter#129198
@christopherfujino christopherfujino mentioned this pull request Nov 7, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Nov 20, 2023
@christopherfujino
CP catch StdinException when setting terminal to SingleCharMode (#138032
20467ba 
)

Original tracking issue: #129198
Original PR: #136283
CP Request: #138040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkolos andrewkolos andrewkolos approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flutter_tools] "OS Error: The handle is invalid" while trying to set echo mode on STDIN

2 participants

@christopherfujino @andrewkolos