Skip to content

_RenderSnapshotWidget should dispose created OffsetLayer. [prod-leak-fix] #136267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 2 commits into from
Oct 11, 2023
Merged

_RenderSnapshotWidget should dispose created OffsetLayer. [prod-leak-fix] #136267

polina-c merged 2 commits into from
Oct 11, 2023

Conversation

@ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented Oct 10, 2023

Description

Tests

  • Removes ignoring of the OffsetLayer leak from snapshot_widget_test.dart;
  • Updates snapshot_widget_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 10, 2023
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Oct 10, 2023

cc @polina-c

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Oct 10, 2023
@polina-c polina-c merged commit cc41e25 into flutter:master Oct 11, 2023
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Oct 11, 2023

@polina-c, thanks for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
0449b23 
…utter/flutter#136267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
a62a3d0 
…utter/flutter#136267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
8eca43a 
…utter/flutter#136267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
4d2ecae 
…utter/flutter#136267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
2328d8f 
…utter/flutter#136267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
673dbc4 
…utter/flutter#136267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
5d8144c 
…utter/flutter#136267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
8c49e17 
…utter/flutter#136267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
836ff5a 
…utter/flutter#136267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
cc613e1 
…utter/flutter#136267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
3f98d24 
…utter/flutter#136267)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
8a9f128 
…utter/flutter#136267)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
cc41e25 _RenderSnapshotWidget should dispose created OffsetLayer. (fl…
9240c56 
…utter/flutter#136267)
@HansMuller HansMuller mentioned this pull request Oct 13, 2023
Closed
@polina-c polina-c changed the title _RenderSnapshotWidget should dispose created OffsetLayer. _RenderSnapshotWidget should dispose created OffsetLayer. [prod-leak-fix] Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Memory Leak: RenderSnapshotWidget does not dispose OffsetLayer

2 participants

@ksokolovskyi @polina-c