Grey out non-selectable days in CupertinoDatePicker #136181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
ShaunByrne-UniSA
force-pushed
the
fix136179
branch
2 times, most recently
from
c38e6cf to
75e8ff1
Compare
MitchellGoodwin
approved these changes
Jan 31, 2024
Contributor
MitchellGoodwin
left a comment
MitchellGoodwin
left a comment
There was a problem hiding this comment.
LGTM! Thank you for putting this together.
Piinks
approved these changes
Jan 31, 2024
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Hey @ShaunByrne-UniSA welcome! Thanks for contributing, LGTM!
Contributor
|
@ShaunByrne-UniSA would you be able to rebase this PR? That would likely get the testing unstuck. |
ShaunByrne-UniSA
force-pushed
the
fix136179
branch
from
75e8ff1 to
463b8d6
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 6, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 6, 2024
Manual roll requested by [email protected] flutter/flutter@0b5cd50...e6ba809 2024-02-06 [email protected] Roll Packages from ae3494d to 1a5a7ce (2 revisions) (flutter/flutter#142985) 2024-02-06 [email protected] TextField context menu should fade on scroll on mobile devices (flutter/flutter#138313) 2024-02-06 [email protected] Roll Flutter Engine from 9c1b6c98f7f0 to 808886312e2b (1 revision) (flutter/flutter#142959) 2024-02-06 [email protected] Roll Flutter Engine from 9bd98bc2fcdf to 9c1b6c98f7f0 (4 revisions) (flutter/flutter#142954) 2024-02-06 [email protected] Roll Flutter Engine from f34c658b9600 to 9bd98bc2fcdf (1 revision) (flutter/flutter#142950) 2024-02-05 [email protected] Grey out non-selectable days in CupertinoDatePicker (flutter/flutter#136181) 2024-02-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.0 to 4.3.1 (flutter/flutter#142944) 2024-02-05 [email protected] Run examples_smoke_test on Linux (flutter/flutter#142736) 2024-02-05 [email protected] Update AGP version validation code to support KGP and kotlin build files. (flutter/flutter#142357) 2024-02-05 [email protected] Fixed test in language_version_test.dart that failed when shuffling, � (flutter/flutter#142904) 2024-02-05 [email protected] Move Mac_build_test flutter_gallery__transition_perf_e2e_ios to staging (flutter/flutter#142918) 2024-02-05 [email protected] Roll Packages from d37fb0a to ae3494d (3 revisions) (flutter/flutter#142915) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the text color of non-selectable days in the CupertinoDatePicker to match non-selectable months and years.
Current:
New:
Fixes #136179
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.