Update BottomSheet test for M3 + fix an issue in elevation resolution #136071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
HansMuller
approved these changes
Oct 6, 2023
| route: this, | ||
| backgroundColor: backgroundColor ?? sheetTheme.modalBackgroundColor ?? sheetTheme.backgroundColor ?? defaults.backgroundColor, | ||
| elevation: elevation ?? sheetTheme.modalElevation ?? defaults.modalElevation ?? sheetTheme.elevation, | ||
| elevation: elevation ?? sheetTheme.modalElevation ?? sheetTheme.elevation ?? defaults.modalElevation, |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 9, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 9, 2023
flutter/flutter@5207a30...f52fe4f 2023-10-09 [email protected] [leak-tracking] Add leak tracking in test/painting #2 (flutter/flutter#136169) 2023-10-09 [email protected] Roll Flutter Engine from 2886353ee612 to 664f5e833871 (1 revision) (flutter/flutter#136195) 2023-10-09 [email protected] Fix `flutter drive` instructions in `Macrobenchmark` README (flutter/flutter#135990) 2023-10-09 [email protected] Update `CircleAvatar` & `DataTable` tests for Material 3 (flutter/flutter#135901) 2023-10-09 [email protected] Roll Flutter Engine from 69ffbd18ab5e to 2886353ee612 (1 revision) (flutter/flutter#136187) 2023-10-09 [email protected] Roll Flutter Engine from 53da096c0c38 to 69ffbd18ab5e (2 revisions) (flutter/flutter#136186) 2023-10-09 [email protected] Roll Flutter Engine from e58a9b3c54b6 to 53da096c0c38 (2 revisions) (flutter/flutter#136182) 2023-10-09 [email protected] Update BottomSheet test for M3 + fix an issue in elevation resolution (flutter/flutter#136071) 2023-10-09 [email protected] Roll Flutter Engine from 7b8f5d4297c6 to e58a9b3c54b6 (1 revision) (flutter/flutter#136175) 2023-10-09 [email protected] Roll Flutter Engine from d5485d67b9f9 to 7b8f5d4297c6 (1 revision) (flutter/flutter#136168) 2023-10-08 [email protected] Roll Flutter Engine from 34ffdf06ca93 to d5485d67b9f9 (1 revision) (flutter/flutter#136158) 2023-10-08 [email protected] Roll Flutter Engine from 0785e3c69f7c to 34ffdf06ca93 (1 revision) (flutter/flutter#136156) 2023-10-08 [email protected] Roll Flutter Engine from 03c8c7724873 to 0785e3c69f7c (2 revisions) (flutter/flutter#136150) 2023-10-08 [email protected] Roll Flutter Engine from eb88bb5b5c4b to 03c8c7724873 (1 revision) (flutter/flutter#136147) 2023-10-08 [email protected] Roll Flutter Engine from 46b05f69187d to eb88bb5b5c4b (1 revision) (flutter/flutter#136145) 2023-10-07 [email protected] Roll Flutter Engine from a18c52768bbc to 46b05f69187d (1 revision) (flutter/flutter#136142) 2023-10-07 [email protected] Roll Flutter Engine from 8711c1fd2191 to a18c52768bbc (6 revisions) (flutter/flutter#136141) 2023-10-07 [email protected] Allow leaks around tap down/up, while flackiness is not fixed. (flutter/flutter#136133) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…flutter#136071) This PR updates unit tests from bottom sheet tests for M3 migration. More info in flutter#127064 It also contains in bottom_sheet.dart where a default value took precedence over a theme attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates unit tests from bottom sheet tests for M3 migration.
More info in #127064
It also contains in bottom_sheet.dart where a default value took precedence over a theme attribute.