Skip to content

Conversation

@TahaTesser
Copy link
Member

fixes Macrobenchmark README.md is out-of-date

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TahaTesser TahaTesser requested a review from goderbauer October 4, 2023 15:18
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 6, 2023
@TahaTesser TahaTesser force-pushed the fix_macrobenchmarks_readme branch from 0d80fff to 51e5013 Compare October 9, 2023 09:09
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 9, 2023

auto label is removed for flutter/flutter/135990, due to - The status or check suite Linux_android android_defines_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2023
@auto-submit auto-submit bot merged commit e5d4575 into flutter:master Oct 9, 2023
@TahaTesser TahaTesser deleted the fix_macrobenchmarks_readme branch October 9, 2023 10:58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 9, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 9, 2023
flutter/flutter@5207a30...f52fe4f

2023-10-09 [email protected] [leak-tracking] Add leak tracking in test/painting #2 (flutter/flutter#136169)
2023-10-09 [email protected] Roll Flutter Engine from 2886353ee612 to 664f5e833871 (1 revision) (flutter/flutter#136195)
2023-10-09 [email protected] Fix `flutter drive` instructions in `Macrobenchmark` README (flutter/flutter#135990)
2023-10-09 [email protected] Update `CircleAvatar` & `DataTable` tests for Material 3 (flutter/flutter#135901)
2023-10-09 [email protected] Roll Flutter Engine from 69ffbd18ab5e to 2886353ee612 (1 revision) (flutter/flutter#136187)
2023-10-09 [email protected] Roll Flutter Engine from 53da096c0c38 to 69ffbd18ab5e (2 revisions) (flutter/flutter#136186)
2023-10-09 [email protected] Roll Flutter Engine from e58a9b3c54b6 to 53da096c0c38 (2 revisions) (flutter/flutter#136182)
2023-10-09 [email protected] Update BottomSheet test for M3 + fix an issue in elevation resolution (flutter/flutter#136071)
2023-10-09 [email protected] Roll Flutter Engine from 7b8f5d4297c6 to e58a9b3c54b6 (1 revision) (flutter/flutter#136175)
2023-10-09 [email protected] Roll Flutter Engine from d5485d67b9f9 to 7b8f5d4297c6 (1 revision) (flutter/flutter#136168)
2023-10-08 [email protected] Roll Flutter Engine from 34ffdf06ca93 to d5485d67b9f9 (1 revision) (flutter/flutter#136158)
2023-10-08 [email protected] Roll Flutter Engine from 0785e3c69f7c to 34ffdf06ca93 (1 revision) (flutter/flutter#136156)
2023-10-08 [email protected] Roll Flutter Engine from 03c8c7724873 to 0785e3c69f7c (2 revisions) (flutter/flutter#136150)
2023-10-08 [email protected] Roll Flutter Engine from eb88bb5b5c4b to 03c8c7724873 (1 revision) (flutter/flutter#136147)
2023-10-08 [email protected] Roll Flutter Engine from 46b05f69187d to eb88bb5b5c4b (1 revision) (flutter/flutter#136145)
2023-10-07 [email protected] Roll Flutter Engine from a18c52768bbc to 46b05f69187d (1 revision) (flutter/flutter#136142)
2023-10-07 [email protected] Roll Flutter Engine from 8711c1fd2191 to a18c52768bbc (6 revisions) (flutter/flutter#136141)
2023-10-07 [email protected] Allow leaks around tap down/up, while flackiness is not fixed. (flutter/flutter#136133)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Macrobenchmark README.md is out-of-date

2 participants