Skip to content

Conversation

@Pante
Copy link
Contributor

@Pante Pante commented Oct 3, 2023

This PR is a trivial change that replaces a dead link in CupertinoPicker's documentation.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Oct 3, 2023
@Pante Pante changed the title Replace dead link in CupertinoPicker documentation Replace dead link in CupertinoPicker documentation Oct 3, 2023
@TahaTesser TahaTesser self-requested a review October 3, 2023 10:34
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Thanks for the fix!

@TahaTesser TahaTesser requested a review from bleroux October 3, 2023 17:07
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 3, 2023
@auto-submit auto-submit bot merged commit 8bd5434 into flutter:master Oct 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 5, 2023
Roll Flutter from 5122991 to fe0275f (35 revisions)

flutter/flutter@5122991...fe0275f

2023-10-05 [email protected] Roll Flutter Engine from 4987e5468152 to f8d53c5fe9f2 (1 revision) (flutter/flutter#136024)
2023-10-05 [email protected] Roll Flutter Engine from a9fe88e09131 to 4987e5468152 (2 revisions) (flutter/flutter#136022)
2023-10-05 [email protected] Roll Flutter Engine from dba8e8d9e6cf to a9fe88e09131 (1 revision) (flutter/flutter#136019)
2023-10-05 [email protected] Roll Flutter Engine from 0ed225c3cc03 to dba8e8d9e6cf (1 revision) (flutter/flutter#136017)
2023-10-05 [email protected] Roll Flutter Engine from 44287139573c to 0ed225c3cc03 (1 revision) (flutter/flutter#136015)
2023-10-05 [email protected] Roll Flutter Engine from 3fea9117be79 to 44287139573c (1 revision) (flutter/flutter#136013)
2023-10-05 [email protected] Roll Flutter Engine from 4d1f8ff52903 to 3fea9117be79 (2 revisions) (flutter/flutter#136012)
2023-10-05 [email protected] Roll Flutter Engine from 8e3a05c9878e to 4d1f8ff52903 (1 revision) (flutter/flutter#136009)
2023-10-05 [email protected] Roll Flutter Engine from 8e6dd239fb1a to 8e3a05c9878e (3 revisions) (flutter/flutter#136007)
2023-10-04 [email protected] Roll Flutter Engine from 80f7023f8d4f to 8e6dd239fb1a (3 revisions) (flutter/flutter#136004)
2023-10-04 [email protected] Marks Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary to be unflaky (flutter/flutter#135960)
2023-10-04 [email protected] Roll Flutter Engine from 459676daff36 to 80f7023f8d4f (1 revision) (flutter/flutter#136001)
2023-10-04 [email protected] Roll Flutter Engine from b0d6bd15e739 to 459676daff36 (2 revisions) (flutter/flutter#135998)
2023-10-04 [email protected] Roll Packages from c7008cf to d654f75 (3 revisions) (flutter/flutter#135996)
2023-10-04 [email protected] Roll Flutter Engine from c9e7d950d2a4 to b0d6bd15e739 (1 revision) (flutter/flutter#135987)
2023-10-04 [email protected] Roll Flutter Engine from e0baf28d05b4 to c9e7d950d2a4 (2 revisions) (flutter/flutter#135967)
2023-10-04 [email protected] Roll Flutter Engine from 1cca24329fa1 to e0baf28d05b4 (2 revisions) (flutter/flutter#135953)
2023-10-04 [email protected] Roll Flutter Engine from 9c0d1f05397f to 1cca24329fa1 (3 revisions) (flutter/flutter#135951)
2023-10-04 [email protected] Roll Flutter Engine from 857f8001f937 to 9c0d1f05397f (1 revision) (flutter/flutter#135947)
2023-10-04 [email protected] Roll Flutter Engine from 2fda8616144c to 857f8001f937 (1 revision) (flutter/flutter#135945)
2023-10-04 [email protected] Roll Flutter Engine from 2ae2cc07d48a to 2fda8616144c (1 revision) (flutter/flutter#135943)
2023-10-04 [email protected] Roll Flutter Engine from 88a234b860ba to 2ae2cc07d48a (1 revision) (flutter/flutter#135940)
2023-10-04 [email protected] Bump dart-lang/native deps (flutter/flutter#135905)
2023-10-04 [email protected] Roll Flutter Engine from eef2449ff80b to 88a234b860ba (1 revision) (flutter/flutter#135939)
2023-10-04 [email protected] Roll Flutter Engine from 8ab7c8841ee5 to eef2449ff80b (4 revisions) (flutter/flutter#135938)
2023-10-03 [email protected] Roll Flutter Engine from be64d0c01184 to 8ab7c8841ee5 (3 revisions) (flutter/flutter#135937)
2023-10-03 [email protected] Roll Flutter Engine from f209923f92c6 to be64d0c01184 (1 revision) (flutter/flutter#135933)
2023-10-03 [email protected] Roll Flutter Engine from 1656dc4a8c63 to f209923f92c6 (1 revision) (flutter/flutter#135927)
2023-10-03 [email protected] Roll Flutter Engine from db168beeae92 to 1656dc4a8c63 (3 revisions) (flutter/flutter#135923)
2023-10-03 [email protected] Add support for `setup` steps in flutter customer tests (flutter/flutter#135726)
2023-10-03 [email protected] Roll Flutter Engine from 7c4f5e924bdb to db168beeae92 (2 revisions) (flutter/flutter#135919)
2023-10-03 [email protected] Replace dead link in `CupertinoPicker` documentation (flutter/flutter#135897)
2023-10-03 [email protected] Roll Flutter Engine from 675a7e456d49 to 7c4f5e924bdb (2 revisions) (flutter/flutter#135918)
2023-10-03 [email protected] Roll Flutter Engine from 74f4d3fc3179 to 675a7e456d49 (2 revisions) (flutter/flutter#135915)
2023-10-03 [email protected] Remove unused InlineSpan methods (flutter/flutter#135882)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
...
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants