Fix memory leaks in WidgetInspector and WidgetInspectorService. [prod-leak-fix] #135828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
Contributor
Author
|
cc @polina-c |
polina-c
reviewed
Oct 1, 2023
| containerLayer.offset = offset; | ||
| } | ||
|
|
||
| /// Releases allocated resources. |
Contributor
There was a problem hiding this comment.
Can you add @mustCallSuper?
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. I added @mustCallSuper in the latest commit.
polina-c
added
the
a: leak tracking
polina-c
approved these changes
Oct 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 2, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 2, 2023
flutter/flutter@d42313c...57ed724 2023-10-02 [email protected] Update dialog tests for Material3 (flutter/flutter#135775) 2023-10-02 [email protected] Roll Flutter Engine from 1410d689bd0a to 321139f5821e (2 revisions) (flutter/flutter#135843) 2023-10-02 [email protected] Roll Flutter Engine from 8b63d286b51a to 1410d689bd0a (1 revision) (flutter/flutter#135840) 2023-10-02 [email protected] Roll Flutter Engine from 9ccf85f09e73 to 8b63d286b51a (1 revision) (flutter/flutter#135838) 2023-10-02 [email protected] Roll Flutter Engine from 10b930ad1adf to 9ccf85f09e73 (1 revision) (flutter/flutter#135837) 2023-10-02 [email protected] Test cover cupertino text field for memory leaks. (flutter/flutter#135804) 2023-10-02 [email protected] Fix memory leaks in WidgetInspector and WidgetInspectorService. (flutter/flutter#135828) 2023-10-01 [email protected] leak track page_test.dart (flutter/flutter#135352) 2023-10-01 [email protected] Roll Flutter Engine from fff38de45ef7 to 10b930ad1adf (1 revision) (flutter/flutter#135835) 2023-10-01 [email protected] Leak track cupertino widgets (flutter/flutter#135353) 2023-10-01 [email protected] Roll Flutter Engine from 310ad4666445 to fff38de45ef7 (1 revision) (flutter/flutter#135830) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
polina-c
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several memory leaks in the
widget_inspector.dart.Description
Tests
widget_inspector_test.dartto usetestWidgetsWithLeakTracking.Pre-launch Checklist
///).