Skip to content

Seperate localization tests for Material2 and Material3 #135779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Oct 10, 2023
Merged

Seperate localization tests for Material2 and Material3 #135779

auto-submit merged 2 commits into from
Oct 10, 2023

Conversation

@MitchellGoodwin
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin commented Sep 29, 2023

Seperates tests for the localizations package into Material2 and Material3 versions and removes dependency on theme.

More info in #127064

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. a: internationalization Supporting other languages or locales. (aka i18n) labels Sep 29, 2023
TahaTesser
TahaTesser approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2023
@MitchellGoodwin MitchellGoodwin force-pushed the localizations-material3-tests branch from 5db27ce to 98f8c8e Compare October 10, 2023 17:14
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 10, 2023

auto label is removed for flutter/flutter/135779, due to - The status or check suite Linux build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2023
@MitchellGoodwin MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2023
@auto-submit auto-submit bot merged commit daa52b2 into flutter:master Oct 10, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
85fcf8e 
…ter/flutter#135779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
fe3ef85 
…ter/flutter#135779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
2d831b8 
…ter/flutter#135779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
310ecae 
…ter/flutter#135779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
13b9775 
…ter/flutter#135779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
1cd9022 
…ter/flutter#135779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
d24a8f6 
…ter/flutter#135779)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
d7dcde3 
…ter/flutter#135779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
1a658cb 
…ter/flutter#135779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
aec82e0 
…ter/flutter#135779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
27cef60 
…ter/flutter#135779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
e432f9b 
…ter/flutter#135779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
4758e3b 
…ter/flutter#135779)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
daa52b2 Seperate localization tests for Material2 and Material3 (flut…
c32a0b0 
…ter/flutter#135779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

@QuncCccccc QuncCccccc Awaiting requested review from QuncCccccc

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MitchellGoodwin @HansMuller @TahaTesser