Skip to content

Remove assertions on getOffsetToReveal #135634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Piinks merged 4 commits into from
Sep 28, 2023
Merged

Remove assertions on getOffsetToReveal #135634

Piinks merged 4 commits into from
Sep 28, 2023

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 27, 2023 •
edited
Loading

Loosens up getOffsetToReveal by removing assertions from #135182

I have been playing around with some diagrams for all of the viewports Flutter has, since I have found some can create issues from inconsistencies if you only have a RenderAbstractViewport object and do not know what kind it is. Maybe an opportunity (or several) to improve here.

graph TB;
  id1((RenderAbstractViewport)) --> RenderListWheelViewport
  id1((RenderAbstractViewport)) --> _RenderSingleChildViewport
  id1((RenderAbstractViewport)) --> id2((RenderTwoDimensionalViewport))
  id1((RenderAbstractViewport)) --> id3((RenderViewportBase))
  id3((RenderViewportBase)) --> RenderShrinkWrappingViewport
  id3((RenderViewportBase)) --> RenderViewport
Loading

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 27, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Sep 27, 2023
chunhtai
chunhtai approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks requested a review from chunhtai September 27, 2023 23:38
chunhtai
chunhtai approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2023
@Piinks Piinks merged commit 3509a1d into flutter:master Sep 28, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2023
@engine-flutter-autoroll
3509a1d Remove assertions on getOffsetToReveal (flutter/flutter#135634)
6898cfb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2023
@engine-flutter-autoroll
3509a1d Remove assertions on getOffsetToReveal (flutter/flutter#135634)
e3f6355
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 29, 2023
@engine-flutter-autoroll
Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (#5036)
5862201 
Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions)

flutter/flutter@ff4a0f6...57b5c3c

2023-09-29 [email protected] Roll Packages from c070b0a to d0e9a0e (5 revisions) (flutter/flutter#135753)
2023-09-29 [email protected] Roll Flutter Engine from db4d3b5b3f59 to c52251a8b2d0 (1 revision) (flutter/flutter#135748)
2023-09-29 [email protected] Roll Flutter Engine from 8b4e633c65eb to db4d3b5b3f59 (2 revisions) (flutter/flutter#135745)
2023-09-29 [email protected] Roll Flutter Engine from 09130bf5be97 to 8b4e633c65eb (1 revision) (flutter/flutter#135744)
2023-09-29 [email protected] Roll Flutter Engine from ccb30585d3f3 to 09130bf5be97 (1 revision) (flutter/flutter#135741)
2023-09-29 [email protected] Roll Flutter Engine from 2052515c44f3 to ccb30585d3f3 (1 revision) (flutter/flutter#135737)
2023-09-29 [email protected] Update localizations. (flutter/flutter#135691)
2023-09-29 [email protected] Roll Flutter Engine from 485543c6765a to 2052515c44f3 (4 revisions) (flutter/flutter#135732)
2023-09-29 [email protected] Add arch property for windows_arm64 platform (flutter/flutter#135725)
2023-09-29 [email protected] [flutter_tools] remove VmService screenshot for native devices. (flutter/flutter#135462)
2023-09-29 [email protected] Pin leak_tracker before publishing breaking change. (flutter/flutter#135720)
2023-09-28 [email protected] Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (flutter/flutter#135717)
2023-09-28 [email protected] Remove assertions on getOffsetToReveal (flutter/flutter#135634)
2023-09-28 [email protected] Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (flutter/flutter#135565)
2023-09-28 [email protected] Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (flutter/flutter#135701)
2023-09-28 [email protected] [tool] fallback to sigkill when closing Chromium (flutter/flutter#135521)
2023-09-28 [email protected] Roll pub packages (flutter/flutter#135455)
2023-09-28 [email protected] Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (flutter/flutter#135694)
2023-09-28 [email protected] Fix TabBarView.viewportFraction change is ignored (flutter/flutter#135590)
2023-09-28 [email protected] Roll Flutter Engine from d9eaebd05851 to 9789dbc2ec3f (2 revisions) (flutter/flutter#135688)
2023-09-28 [email protected] Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) (flutter/flutter#132361)
2023-09-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" (flutter/flutter#135692)
2023-09-28 [email protected] ð��� Add more fields to `RefreshProgressIndicator` (flutter/flutter#135207)
2023-09-28 [email protected] Roll Flutter Engine from 82b69dadc07a to d9eaebd05851 (1 revision) (flutter/flutter#135679)
2023-09-28 [email protected] Add API to read flavor from framework at run time (flutter/flutter#134179)
2023-09-28 [email protected] Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135567)
2023-09-28 [email protected] [web] fix: do not call onSubmitted of TextField when switching browser tabs on mobile web (flutter/flutter#134870)
2023-09-28 [email protected] Roll Packages from 21c2ebb to c070b0a (3 revisions) (flutter/flutter#135676)
2023-09-28 [email protected] Fix `RangeSlider` throws an exception in a `ListView` (flutter/flutter#135667)
2023-09-28 [email protected] Roll Flutter Engine from d09c2dbe2292 to 82b69dadc07a (2 revisions) (flutter/flutter#135675)
2023-09-28 [email protected] Roll Flutter Engine from 495955a3b5de to d09c2dbe2292 (1 revision) (flutter/flutter#135669)
2023-09-28 [email protected] Revert "Upload generated frame-request-pending stats" (flutter/flutter#135672)
2023-09-28 [email protected] Upload generated frame-request-pending stats (flutter/flutter#135645)
2023-09-28 [email protected] Roll Flutter Engine from 937bf0432214 to 495955a3b5de (1 revision) (flutter/flutter#135665)
2023-09-28 [email protected] Roll Flutter Engine from d2540d87fd96 to 937bf0432214 (1 revision) (flutter/flutter#135660)
2023-09-28 [email protected] Roll Flutter Engine from c47faed53afe to d2540d87fd96 (2 revisions) (flutter/flutter#135652)
2023-09-28 [email protected] Update `TextField.style` documentation for Material 3 (flutter/flutter#135556)
2023-09-28 [email protected] Roll Flutter Engine from 44aef2e61718 to c47faed53afe (1 revision) (flutter/flutter#135647)
2023-09-28 [email protected] Manual roll Flutter Engine from be32dcc9117a to 44aef2e61718 (4 revisions) (flutter/flutter#135646)
2023-09-28 [email protected] Manual roll Flutter Engine from f70f65f7a622 to be32dcc9117a (31 revisions) (flutter/flutter#135637)
2023-09-28 [email protected] Implement SelectionArea single click/tap gestures (flutter/flutter#132682)
2023-09-27 [email protected] Support ensureVisible/showOnScreen/showInViewport for 2D Scrolling (flutter/flutter#135182)
2023-09-27 [email protected] made top level if checks gaurd clauses (flutter/flutter#135070)
2023-09-27 [email protected] Fix `SearchAnchor`'s search view isn't updated when the theme changes & widgets inside the search view do not inherit local themes (flutter/flutter#132749)
2023-09-27 [email protected] Config changes for linux coverage. (flutter/flutter#135604)
2023-09-27 [email protected] Roll Packages from 619af75 to 21c2ebb (6 revisions) (flutter/flutter#135602)
...
@HansMuller HansMuller mentioned this pull request Sep 29, 2023
Closed
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@Piinks @Mairramer
Remove assertions on getOffsetToReveal (flutter#135634)
e1220fa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
3509a1d Remove assertions on getOffsetToReveal (flutter/flutter#135634)
1955470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Piinks @chunhtai