[Windows] Add first Arm64 plugin tests #135512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovschectman
approved these changes
Sep 26, 2023
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 7, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 7, 2023
flutter/flutter@ad20089...5207a30 2023-10-07 [email protected] Roll Flutter Engine from 40024059b09e to 8711c1fd2191 (1 revision) (flutter/flutter#136110) 2023-10-07 [email protected] Roll Flutter Engine from eaac056b63a4 to 40024059b09e (1 revision) (flutter/flutter#136108) 2023-10-07 [email protected] Roll Flutter Engine from f71778651333 to eaac056b63a4 (1 revision) (flutter/flutter#136107) 2023-10-07 [email protected] bottom_sheet: Clarify doc about behavior when useSafeArea is false (flutter/flutter#134793) 2023-10-07 [email protected] Roll Flutter Engine from 356ab2a54862 to f71778651333 (1 revision) (flutter/flutter#136106) 2023-10-07 [email protected] Roll Flutter Engine from 1f79667fb860 to 356ab2a54862 (1 revision) (flutter/flutter#136104) 2023-10-07 [email protected] Simplify assertion in `AsyncSnapshot` (flutter/flutter#135899) 2023-10-07 [email protected] Roll Flutter Engine from b28032c157ee to 1f79667fb860 (1 revision) (flutter/flutter#136103) 2023-10-06 [email protected] Roll Flutter Engine from 7bf93bb919d9 to b28032c157ee (1 revision) (flutter/flutter#136101) 2023-10-06 [email protected] Roll Flutter Engine from eb5d5c66a83e to 7bf93bb919d9 (2 revisions) (flutter/flutter#136098) 2023-10-06 [email protected] [Windows] Add first Arm64 plugin tests (flutter/flutter#135512) 2023-10-06 [email protected] Roll Flutter Engine from 1bb228dfedfa to eb5d5c66a83e (2 revisions) (flutter/flutter#136094) 2023-10-06 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.22.0 (flutter/flutter#136095) 2023-10-06 [email protected] Call `markNeedsPaint` when adding overlayChild to `Overlay` (flutter/flutter#135941) 2023-10-06 [email protected] Revert "Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky" (flutter/flutter#136097) 2023-10-06 [email protected] Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky (flutter/flutter#135566) 2023-10-06 [email protected] Roll Flutter Engine from 59b6b94e1a51 to 1bb228dfedfa (1 revision) (flutter/flutter#136082) 2023-10-06 [email protected] RenderEditable should dispose created layers. (flutter/flutter#135942) 2023-10-06 [email protected] Marks Windows module_custom_host_app_name_test to be unflaky (flutter/flutter#135961) 2023-10-06 [email protected] Roll Packages from 6714d50 to e578a16 (2 revisions) (flutter/flutter#136074) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
Part of: flutter#129806 Test runs kicked off using `led`: * â�� [plugin_test_windows](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/277ffb2c7bdaad579b7598706ebc4009797211bea6b3fd175f0a2e9ad8fe03b1/+/build.proto?server=chromium-swarm.appspot.com) * â� ï¸� [plugin_test](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/c9daccd5b3c6b33763fdb36da30cd55949c7e98539041726bd659d19e1d49112/+/build.proto?server=chromium-swarm.appspot.com) - This test fails as no existing Windows Arm64 builder install the `android_sdk` and `open_jdk` dependencies I will add `plugin_dependencies_test` and `gradle_plugin_bundle_test` in a follow-up pull request. These tests also depend on `android_sdk` and `open_jdk`, I'll be able to test them manually using the new `plugin_test` builder added by this pull request. /cc @pbo-linaro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #129806
Test runs kicked off using
led:android_sdkandopen_jdkdependenciesI will add
plugin_dependencies_testandgradle_plugin_bundle_testin a follow-up pull request. These tests also depend onandroid_sdkandopen_jdk, I'll be able to test them manually using the newplugin_testbuilder added by this pull request./cc @pbo-linaro
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.