Revert engine #13547
Merged
Revert engine #13547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3af6b9c.
)" This reverts commit 08128cb.
…ets (flutter#13544)" This reverts commit 35f1a04.
Contributor
Author
|
TBR: submitting on red build to unbreak the build. |
Contributor
|
|
szakarias
added a commit
to szakarias/flutter
that referenced
this pull request
Dec 14, 2017
This reverts commit ee65db1.
szakarias
added a commit
that referenced
this pull request
Dec 14, 2017
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Revert "Include a directory with Flutter assets (flutter#12944)" This reverts commit 3af6b9c. * Revert "Upgrade project.pbxproj to include flutter_assets (flutter#13011)" This reverts commit 08128cb. * Revert "Upgrade complex_layout project.pbxproj to include flutter_assets (flutter#13544)" This reverts commit 35f1a04. * mark complex_layout_ios__start_up as flaky
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Revert "Revert engine (flutter#13547)" This reverts commit ee65db1. * Keep flaky mark
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual test on a Windows bot shows Flutter coming up with a blank screen and no observatory connection. I'm reverting the series of commits by @szakarias starting with the engine roll onwards.
I'm also marking
complex_layout_ios__start_upas flaky.