Skip to content

Cover more test/widgets tests with leak tracking #11 #135231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 1 commit into from
Sep 21, 2023
Merged

Cover more test/widgets tests with leak tracking #11 #135231

polina-c merged 1 commit into from
Sep 21, 2023

Conversation

@ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented Sep 21, 2023

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Tests

  • Updates text_semantics_test.dart to use testWidgetsWithLeakTracking;
  • Updates text_test.dart to use testWidgetsWithLeakTracking;
  • Updates texture_test.dart to use testWidgetsWithLeakTracking;
  • Updates ticker_mode_test.dart to use testWidgetsWithLeakTracking;
  • Updates ticker_provider_test.dart to use testWidgetsWithLeakTracking;
  • Updates title_test.dart to use testWidgetsWithLeakTracking;
  • Updates tracking_scroll_controller_test.dart to use testWidgetsWithLeakTracking;
  • Updates transformed_scrollable_test.dart to use testWidgetsWithLeakTracking;
  • Updates transitions_test.dart to use testWidgetsWithLeakTracking;
  • Updates tree_shape_test.dart to use testWidgetsWithLeakTracking;
  • Updates tween_animation_builder_test.dart to use testWidgetsWithLeakTracking;
  • Updates two_dimensional_scroll_view_test.dart to use testWidgetsWithLeakTracking;
  • Updates two_dimensional_viewport_test.dart to use testWidgetsWithLeakTracking;
  • Updates undo_history_test.dart to use testWidgetsWithLeakTracking;
  • Updates unique_widget_test.dart to use testWidgetsWithLeakTracking;
  • Updates value_listenable_builder_test.dart to use testWidgetsWithLeakTracking;
  • Updates view_test.dart to use testWidgetsWithLeakTracking;
  • Updates visibility_test.dart to use testWidgetsWithLeakTracking;
  • Updates wrap_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository labels Sep 21, 2023
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 21, 2023

cc @polina-c

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 21, 2023
@polina-c polina-c merged commit ffecedb into flutter:master Sep 21, 2023
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 22, 2023

@polina-c thanks for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
367c005 
…lutter/flutter#135231)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
c8a8f20 
…lutter/flutter#135231)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
b5a2d0f 
…lutter/flutter#135231)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
e00de03 
…lutter/flutter#135231)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
c8db881 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
cbfa1a1 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
cb517e3 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
9b30d66 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
0eb65d3 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
7c10a23 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
bca41d6 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
e624021 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
b36c3f1 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
828cc39 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
ad43d9b 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
4dc8646 
…lutter/flutter#135231)
@HansMuller HansMuller mentioned this pull request Sep 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
7aa48fe 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
6f0e8fa 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
46f55f4 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
a9c5f5e 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
96317a6 
…lutter/flutter#135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
f5bc170 
…lutter/flutter#135231)
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@ksokolovskyi @Mairramer
Cover more test/widgets tests with leak tracking flutter#11 (flutter#…
a056db4 
…135231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
ffecedb Cover more test/widgets tests with leak tracking flutter#11 (f…
0f10aa8 
…lutter/flutter#135231)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ksokolovskyi @polina-c