Skip to content

Fix memory leak in _MatchesReferenceImage #135150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 5 commits into from
Sep 22, 2023
Merged

Fix memory leak in _MatchesReferenceImage #135150

polina-c merged 5 commits into from
Sep 22, 2023

Conversation

@ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented Sep 20, 2023

This PR fixes a memory leak in the _MatchesReferenceImage, which did not dispose created ui.Image.

Description

Tests

  • Adds new test to packages/flutter_test/test/reference_image_test.dart to verify that matchesReferenceImage matcher works with widget finders and disposes created ui.Image;
  • Updates packages/flutter_test/test/reference_image_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Sep 20, 2023
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 20, 2023

cc @polina-c

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 20, 2023
polina-c
polina-c requested changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment.

@polina-c polina-c merged commit a4e3f93 into flutter:master Sep 22, 2023
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 23, 2023

@polina-c thanks for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
26a3cc5 
…5150)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
a48e25f 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
7c9f993 
…5150)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
94fedcd 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
5804650 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
cb3d0d0 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
cefb188 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
1e023b6 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
765a404 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
88ba54a 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
4da17eb 
…5150)
@HansMuller HansMuller mentioned this pull request Sep 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
dfc85c1 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
5fc7705 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
7ac8722 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
8984d3f 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
87165f2 
…5150)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
41f1f24 
…5150)
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@ksokolovskyi @Mairramer
Fix memory leak in _MatchesReferenceImage (flutter#135150)
c02f738
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
a4e3f93 Fix memory leak in _MatchesReferenceImage (flutter/flutter#13…
757e0cf 
…5150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Memory Leak: _MatchesReferenceImage matcher does not dispose ui.Image

2 participants

@ksokolovskyi @polina-c