Skip to content

Cover some cupertino tests with leak tracing #135149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 31 commits into from
Sep 21, 2023
Merged

Cover some cupertino tests with leak tracing #135149

polina-c merged 31 commits into from
Sep 21, 2023

Conversation

@derdilla
Copy link
Contributor

@derdilla derdilla commented Sep 20, 2023

This PR covers the Cupertino tests that already have no leaks with leak tracing as discussed in #123.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@derdilla
update tab_scaffold_test.dart
f56513f
@derdilla
Merge branch 'flutter:master' into test-cupertino-no-problems
8434a91
@derdilla
update activity_indicator_test.dart
6362ae2
@derdilla
update adaptive_text_selection_toolbar_test.dart and fix notDisposed
caf817b
@derdilla
Merge branch 'flutter:master' into test-cupertino-no-problems
92a5345
@derdilla
update cupertino/bottom_tab_bar_test
3f7e52e
@derdilla
update cupertino/button_test
5654de8
@derdilla
update cupertino/checkbox_test
335bac1
@derdilla
update colors_test.dart
7cd081e
@derdilla
update context_menu_action_test.dart
d45488b
@derdilla
merge upstream
750628f
@derdilla
update context_menu_test.dart
176a6ec
@derdilla
update debug_test.dart
72b5e69
@derdilla
update desktop_text_selection_toolbar_button_test.dart
7165f4b
@derdilla
update desktop_text_selection_toolbar_test.dart
bf77e89
@derdilla
update form_row_test.dart
57f6b9f
@derdilla
update icon_theme_data_test.dart
9d26844
@derdilla
update list_section_test.dart
2313b12
@derdilla
update list_tile_test.dart
16e77e4
@derdilla
update localizations_test.dart
26f9ad1
@derdilla
update refresh_test.dart
c3029ad
@derdilla
update route_test.dart
eddadd9
@derdilla
update scrollbar_paint_test.dart
75ff81e
@derdilla
update segmented_control_test.dart
f3a8c10
@derdilla
update slider_test.dart
efc2ce7
@derdilla
update tab_test.dart
2c38b2c
@derdilla
update text_field_restoration_test.dart
6c3d8a4
@derdilla
update text_selection_toolbar_button_test.dart
01f64ec
@derdilla
update text_selection_toolbar_test.dart
d4e7f12
@derdilla
update theme_test.dart
8902eff
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
6eb8dec 
…#135149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
bd3f3e2 
…#135149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
a2da719 
…#135149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
ec6ae93 
…#135149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
2c0d0a5 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
faf9ffc 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
dd18b48 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
7ec8f5f 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
37f9669 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
ab8f971 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
ad0e8c1 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
29aab09 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
6546482 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
de7f4cf 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
9658962 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
c09c69b 
…#135149)
@HansMuller HansMuller mentioned this pull request Sep 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
877bc91 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
bb8a826 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
cf6d596 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
404d7f1 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
25b0086 
…#135149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
a002ec0 
…#135149)
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@derdilla @Mairramer
Cover some cupertino tests with leak tracing (flutter#135149)
294ab35
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
beeb3ce Cover some cupertino tests with leak tracing (flutter/flutter…
d5c71e8 
…#135149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@derdilla @polina-c