Fix the character field of RawKeyEvent is always null on iOS #135100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
Member
|
(triage): @LinXunFeng The google testing check requires that this branch is rebased in order to run. Sadly, github doesn't allow me to rebase it from my end. Can you please rebase it to the latest master so that we can merge it? |
Member
Author
|
@goderbauer done, the google testing passed. |
dkwingsmt
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 3, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 3, 2023
flutter/flutter@57ed724...5122991 2023-10-03 [email protected] Roll Flutter Engine from ff02c71f1451 to 74f4d3fc3179 (1 revision) (flutter/flutter#135913) 2023-10-03 [email protected] Roll Flutter Engine from 28b758503b57 to ff02c71f1451 (1 revision) (flutter/flutter#135911) 2023-10-03 [email protected] Roll Packages from e2ac440 to c7008cf (4 revisions) (flutter/flutter#135907) 2023-10-03 [email protected] Roll Flutter Engine from c11e7cdd5de5 to 28b758503b57 (3 revisions) (flutter/flutter#135906) 2023-10-03 [email protected] Roll Flutter Engine from 0a60a1d89664 to c11e7cdd5de5 (1 revision) (flutter/flutter#135894) 2023-10-03 [email protected] Roll Flutter Engine from ef86c9d84745 to 0a60a1d89664 (3 revisions) (flutter/flutter#135893) 2023-10-03 [email protected] Roll Flutter Engine from 1549d58b6ed5 to ef86c9d84745 (1 revision) (flutter/flutter#135889) 2023-10-03 [email protected] Fix the character field of RawKeyEvent is always null on iOS (flutter/flutter#135100) 2023-10-03 [email protected] Roll Flutter Engine from 5bc3ab514546 to 1549d58b6ed5 (2 revisions) (flutter/flutter#135887) 2023-10-03 [email protected] Roll Flutter Engine from 0956ef53590a to 5bc3ab514546 (1 revision) (flutter/flutter#135880) 2023-10-02 [email protected] Cover some cupertino tests with leak tracking (flutter/flutter#135230) 2023-10-02 [email protected] leak track tab_scaffold_test.dart (flutter/flutter#135309) 2023-10-02 [email protected] Roll Flutter Engine from 6aa04dca7589 to 0956ef53590a (1 revision) (flutter/flutter#135878) 2023-10-02 [email protected] Roll Flutter Engine from 9aa990133ebc to 6aa04dca7589 (1 revision) (flutter/flutter#135872) 2023-10-02 [email protected] Fix a couple of CupertinoTextField tests to avoid leak-tracking test failures. (flutter/flutter#135851) 2023-10-02 [email protected] Roll Flutter Engine from f3a92cb0c4da to 9aa990133ebc (1 revision) (flutter/flutter#135871) 2023-10-02 [email protected] Roll Flutter Engine from b97818f301ba to f3a92cb0c4da (3 revisions) (flutter/flutter#135869) 2023-10-02 [email protected] Roll Flutter Engine from c0cf135b1199 to b97818f301ba (1 revision) (flutter/flutter#135862) 2023-10-02 [email protected] Roll Flutter Engine from 39819e6d306b to c0cf135b1199 (2 revisions) (flutter/flutter#135860) 2023-10-02 [email protected] Roll Packages from d0e9a0e to e2ac440 (12 revisions) (flutter/flutter#135859) 2023-10-02 [email protected] Roll Flutter Engine from 321139f5821e to 39819e6d306b (1 revision) (flutter/flutter#135857) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133956