Skip to content

[deps] Update package:web dependency. #135081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ditman wants to merge 2 commits into from
Closed

[deps] Update package:web dependency. #135081

ditman wants to merge 2 commits into from

Conversation

@ditman
Copy link
Member

@ditman ditman commented Sep 20, 2023

This PR is the result of running:

$ flutter update-packages --force-upgrade

Fixes #135075

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Sep 20, 2023
@ditman ditman mentioned this pull request Sep 20, 2023
Closed
@christopherfujino
Copy link
Contributor

christopherfujino commented Sep 20, 2023

@ditman let's try #134958, which is a superset of this one.

@ditman

This comment was marked as outdated.

Sign in to view
@ditman ditman closed this Sep 20, 2023
@ditman ditman deleted the update-package-web-dep branch September 20, 2023 00:40
@ditman ditman mentioned this pull request Sep 20, 2023
Merged
8 tasks
@christopherfujino
Copy link
Contributor

christopherfujino commented Sep 20, 2023

This will need either a rebase, or to be regenerated from scratch to avoid a merge conflict with #134958 (which unfortunately did not bump package:web)

@christopherfujino
Copy link
Contributor

christopherfujino commented Sep 20, 2023

Unfortunately, I can't re-open the PR as the branch has been deleted (I believe you have this power, though, @ditman )

@ditman ditman restored the update-package-web-dep branch September 20, 2023 17:54
@ditman
Copy link
Member Author

ditman commented Sep 20, 2023

I'll recreate this one, no worries!

@ditman ditman reopened this Sep 20, 2023
christopherfujino
christopherfujino approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. i'll leave it as an exercise for the reader to resolve the git conflict.

@ditman
[deps] Update package:web dependency.
dc4a2a9 
This PR is the result of running:

* flutter upgrade-packages --force-upgrade
@ditman ditman force-pushed the update-package-web-dep branch from 483de0c to dc4a2a9 Compare September 20, 2023 18:05
@ditman
Copy link
Member Author

ditman commented Sep 20, 2023

This one is much cleaner now @christopherfujino! I'll add the autosubmit label. Thanks for the quick review!

@ditman ditman changed the title [deps] Update package:web dependency (and others). [deps] Update package:web dependency. Sep 20, 2023
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 20, 2023

auto label is removed for flutter/flutter/135081, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 20, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #135081 at sha dc4a2a9

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Sep 20, 2023
@ditman
Copy link
Member Author

ditman commented Sep 20, 2023

"No results matched your search criteria." take another look flutter-dashboard!

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 20, 2023

auto label is removed for flutter/flutter/135081, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ditman
Copy link
Member Author

ditman commented Sep 20, 2023

I should have pushed an empty commit, rather than rebasing the branch 🤦

@ditman
Copy link
Member Author

ditman commented Sep 20, 2023

Let's try and recreate this from scratch, and see what FRoB thinks :)

@ditman ditman closed this Sep 20, 2023
@ditman ditman mentioned this pull request Sep 20, 2023
Merged
8 tasks
@ditman ditman deleted the update-package-web-dep branch September 20, 2023 21:21
auto-submit bot pushed a commit that referenced this pull request Sep 20, 2023
@ditman
[deps] Update package:web dependency. (#135174)
a4bc894 
This PR is the result of running:

```console
$ flutter upgrade-packages --force-upgrade
```

### Issues

* Fixes #135075
* Supersedes #135081
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@ditman @Mairramer
[deps] Update package:web dependency. (flutter#135174)
ad49916 
This PR is the result of running:

```console
$ flutter upgrade-packages --force-upgrade
```

### Issues

* Fixes flutter#135075
* Supersedes flutter#135081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump pkg:web across repo to 0.2.1-beta

2 participants

@ditman @christopherfujino