Skip test temporarily until headingLevel is added in engine (issue 41… #135077

victorgalo · 2023-09-19T23:51:47Z

The purpose of this PR is to temporarily skip one integration test that is blocking the changes indicated below:

(This change adds a new property in Semantics widget that would take an integer corresponding to the heading levels defined by the ARIA heading role. This is necessary in order to get proper accessibility and usability in a website for users who rely on screen readers and other assistive technologies.)

Issue fixed by this PR:
#97894

Engine part:
flutter/engine#41435

Framework part:
#125771

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

…435)

chunhtai

There is also a similar test in custom_painter you need to skip

Piinks · 2023-10-17T22:09:54Z

(triage) Hi @victorgalo are you planning on returning to this change? @chunhtai mentioned one more test case, and it looks like there is a merge conflict that need resolving.

victorgalo · 2023-11-12T14:46:53Z

custom_painter

Hi @Piinks sure!, I will. Sorry for taking so long to deal with this.

victorgalo · 2023-11-14T22:50:10Z

There is also a similar test in custom_painter you need to skip

Hi @chunhtai, sorry to ask this but which test?, I tried to find a similar conflicting test but couldn't find any. As far as I can see the branch for the engine change is only throwing failure in the tests that I skipped.

chunhtai · 2023-11-27T18:44:11Z

I think it is one of these test

flutter/packages/flutter/test/widgets/custom_painter_test.dart

Line 414 in bf5d2b8

testWidgetsWithLeakTracking('Supports all flags', (WidgetTester tester) async {

I think the engine smoke test would have failed the test, if not, I think it should be fine then

victorgalo · 2023-12-04T23:34:34Z

I think it is one of these test

flutter/packages/flutter/test/widgets/custom_painter_test.dart

Line 414 in bf5d2b8

testWidgetsWithLeakTracking('Supports all flags', (WidgetTester tester) async {

I think the engine smoke test would have failed the test, if not, I think it should be fine then

Hi @chunhtai, oh ok, but I think neither of those will fail, we can leave them. Thank you!

chunhtai

LGTM

packages/flutter/test/semantics/semantics_update_test.dart

victorgalo · 2024-02-11T22:15:04Z

Hi @yjbanov, can you take a look to this please?, I need your approval to get this landed, and this PR is currently blocking these other PR's:
flutter/engine#41435
#125771

Thank you!

kevmoo · 2024-02-25T20:52:43Z

Please look at the suggestions @victorgalo !

FrancescoAbbondo · 2024-03-05T10:09:41Z

Hello @yjbanov @chunhtai, can you give me a date (even indicative) for the release of this feature into Flutter? When the PR will be approved? Thanks a lot

kevmoo · 2024-03-05T15:40:17Z

@FrancescoAbbondo – please see the suggestions!!!

Co-authored-by: chunhtai <[email protected]>

victorgalo · 2024-03-09T20:26:57Z

Please look at the suggestions @victorgalo !

stupid me, sorry for overlooking the suggestions! now they are added.

auto-submit · 2024-03-09T23:18:07Z

auto label is removed for flutter/flutter/135077, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2024-03-09T23:28:04Z

auto label is removed for flutter/flutter/135077, due to - The status or check suite Linux web_canvaskit_tests_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux web_tests_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2024-03-09T23:57:22Z

auto label is removed for flutter/flutter/135077, due to - The status or check suite Linux framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

…issue 41… (flutter/flutter#135077)

Manual roll requested by [email protected] flutter/flutter@3bb2e59...1ca8873 2024-03-12 [email protected] Update integration tests regexes. (flutter/flutter#144847) 2024-03-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fail tests on exceptions raised after test completed (#144706)" (flutter/flutter#144970) 2024-03-11 [email protected] Make TabController communicating creation in constructor. (flutter/flutter#144912) 2024-03-11 [email protected] Fail tests on exceptions raised after test completed (flutter/flutter#144706) 2024-03-11 [email protected] Refactoring `if` chains into `switch` statements (flutter/flutter#144905) 2024-03-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Expose build mode in environment of asset transformer processes (#144752)" (flutter/flutter#144957) 2024-03-11 [email protected] Expose build mode in environment of asset transformer processes (flutter/flutter#144752) 2024-03-11 [email protected] Roll Flutter Engine from 9196947bc687 to 6745955bb49e (2 revisions) (flutter/flutter#144946) 2024-03-11 [email protected] Skip test temporarily until headingLevel is added in engine (issue 41â�¦ (flutter/flutter#135077) 2024-03-11 [email protected] Roll Flutter Engine from 3b0b59bb224d to 9196947bc687 (1 revision) (flutter/flutter#144934) 2024-03-11 [email protected] Roll Packages from 0badb43 to d489d84 (3 revisions) (flutter/flutter#144931) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…issue 41… (flutter/flutter#135077)

Skip test temporarily until headingLevel is added in engine (issue 41…

e3e714e

…435)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Sep 19, 2023

victorgalo mentioned this pull request Sep 19, 2023

Add support for setting the heading level for web semantics (#97894) #125771

Merged

8 tasks

goderbauer requested review from chunhtai and yjbanov September 26, 2023 22:16

chunhtai reviewed Sep 26, 2023

View reviewed changes

victorgalo added 3 commits November 12, 2023 15:49

Merge branch 'master' into add-semantics-heading-level-skip-test

ea028d6

Merge branch 'master' into add-semantics-heading-level-skip-test

fb7112c

Merge branch 'master' into add-semantics-heading-level-skip-test

ffdd08b

victorgalo requested a review from chunhtai November 23, 2023 18:18

Merge branch 'master' into add-semantics-heading-level-skip-test

b251ad2

chunhtai approved these changes Dec 7, 2023

View reviewed changes

packages/flutter/test/semantics/semantics_update_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/semantics/semantics_update_test.dart Outdated Show resolved Hide resolved

victorgalo mentioned this pull request Feb 25, 2024

Add support for setting the heading level for web semantics (#97894) flutter/engine#41435

Merged

8 tasks

Merge branch 'master' into add-semantics-heading-level-skip-test

19bc312

victorgalo and others added 3 commits March 9, 2024 21:25

Merge branch 'master' into add-semantics-heading-level-skip-test

c420ae7

Update packages/flutter/test/semantics/semantics_update_test.dart

08cbcd3

Co-authored-by: chunhtai <[email protected]>

Update packages/flutter/test/semantics/semantics_update_test.dart

1456183

Co-authored-by: chunhtai <[email protected]>

kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2024

kevmoo approved these changes Mar 9, 2024

View reviewed changes

kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2024

kevmoo force-pushed the add-semantics-heading-level-skip-test branch from a715746 to 1456183 Compare March 9, 2024 23:33

kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2024

Merge branch 'master' into add-semantics-heading-level-skip-test

7573545

kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2024

auto-submit bot merged commit b9afa60 into flutter:master Mar 11, 2024

engine-flutter-autoroll mentioned this pull request Mar 12, 2024

Manual roll Flutter from 3bb2e5948e7a to 1ca88730a0c1 (11 revisions) flutter/packages#6304

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2024

b9afa60 Skip test temporarily until headingLevel is added in engine (…

5b7fa33

…issue 41… (flutter/flutter#135077)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

b9afa60 Skip test temporarily until headingLevel is added in engine (…

93523c6

…issue 41… (flutter/flutter#135077)

Skip test temporarily until headingLevel is added in engine (issue 41… #135077

Skip test temporarily until headingLevel is added in engine (issue 41… #135077

Uh oh!

Conversation

victorgalo commented Sep 19, 2023

Pre-launch Checklist

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Oct 17, 2023

Uh oh!

victorgalo commented Nov 12, 2023

Uh oh!

victorgalo commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chunhtai commented Nov 27, 2023

Uh oh!

victorgalo commented Dec 4, 2023

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

victorgalo commented Feb 11, 2024

Uh oh!

kevmoo commented Feb 25, 2024

Uh oh!

FrancescoAbbondo commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevmoo commented Mar 5, 2024

Uh oh!

victorgalo commented Mar 9, 2024

Uh oh!

auto-submit bot commented Mar 9, 2024

Uh oh!

auto-submit bot commented Mar 9, 2024

Uh oh!

auto-submit bot commented Mar 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

victorgalo commented Nov 14, 2023 •

edited

Loading

FrancescoAbbondo commented Mar 5, 2024 •

edited

Loading