Skip to content

Cover more test/widgets tests with leak tracking #9 #135054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 3 commits into from
Sep 20, 2023
Merged

Cover more test/widgets tests with leak tracking #9 #135054

polina-c merged 3 commits into from
Sep 20, 2023

Conversation

@ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented Sep 19, 2023

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Tests

  • Updates selection_container_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_10_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_11_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_1_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_2_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_3_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_4_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_5_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_6_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_7_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_8_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_9_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_child_configs_delegate_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_clipping_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_debugger_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_keep_alive_offstage_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_merge_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_tester_generate_test_semantics_expression_for_current_semantics_tree_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_tester_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_traversal_test.dart to use testWidgetsWithLeakTracking;
  • Updates semantics_zero_surface_size_test.dart to use testWidgetsWithLeakTracking;
  • Updates set_state_1_test.dart to use testWidgetsWithLeakTracking;
  • Updates set_state_2_test.dart to use testWidgetsWithLeakTracking;
  • Updates set_state_3_test.dart to use testWidgetsWithLeakTracking;
  • Updates set_state_4_test.dart to use testWidgetsWithLeakTracking;
  • Updates set_state_5_test.dart to use testWidgetsWithLeakTracking;
  • Updates shader_mask_test.dart to use testWidgetsWithLeakTracking;
  • Updates shadow_test.dart to use testWidgetsWithLeakTracking;
  • Updates shape_decoration_test.dart to use testWidgetsWithLeakTracking;
  • Updates shared_app_data_test.dart to use testWidgetsWithLeakTracking;
  • Updates shortcuts_test.dart to use testWidgetsWithLeakTracking;
  • Updates simple_semantics_test.dart to use testWidgetsWithLeakTracking;
  • Updates single_child_scroll_view_test.dart to use testWidgetsWithLeakTracking;
  • Updates size_changed_layout_notification_test.dart to use testWidgetsWithLeakTracking;
  • Updates sized_box_test.dart to use testWidgetsWithLeakTracking;
  • Updates sliver_appbar_opacity_test.dart to use testWidgetsWithLeakTracking;
  • Updates sliver_constrained_cross_axis_test.dart to use testWidgetsWithLeakTracking;
  • Updates sliver_constraints_test.dart to use testWidgetsWithLeakTracking;
  • Updates sliver_cross_axis_group_test.dart to use testWidgetsWithLeakTracking;
  • Updates sliver_fill_remaining_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. labels Sep 19, 2023
@goderbauer goderbauer requested a review from polina-c September 19, 2023 22:16
@polina-c polina-c mentioned this pull request Sep 20, 2023
Closed
@polina-c polina-c merged commit c3db020 into flutter:master Sep 20, 2023
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 20, 2023

@polina-c thanks for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
d14763f 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
4f79a5b 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
894eb56 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
046c5a8 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
575331d 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
f8da7eb 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
69fc3bc 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
f3ab6a6 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
78c5b58 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
de19d95 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
91311f4 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
e43fe5a 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
f8c82a0 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
9504def 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
0d51da3 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
bddaef4 
…lutter/flutter#135054)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
51a3b16 
…lutter/flutter#135054)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
1307247 
…lutter/flutter#135054)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
016e4de 
…lutter/flutter#135054)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
2bc37cc 
…lutter/flutter#135054)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
1480813 
…lutter/flutter#135054)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
7740667 
…lutter/flutter#135054)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
5bbc3e0 
…lutter/flutter#135054)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 23, 2023
@engine-flutter-autoroll
Manual roll Flutter from 8936504 to f92884c (48 revisions) (#4985)
4becde9 
Manual roll Flutter from 8936504 to f92884c (48 revisions)

Manual roll requested by [email protected]

flutter/flutter@8936504...f92884c

2023-09-21 [email protected] Rename `debugProfilePlatformChannels` to a constant that works in release mode (flutter/flutter#134922)
2023-09-20 [email protected] Mark ReastaurationManager not disposed (flutter/flutter#134832)
2023-09-20 [email protected] cover more tests with leak tracing (flutter/flutter#134834)
2023-09-20 [email protected] Fix leak in hardware_keyboard_test.dart (flutter/flutter#134380)
2023-09-20 [email protected] Fix memory leak in _SelectableTextState (flutter/flutter#135049)
2023-09-20 [email protected] Roll Flutter Engine from 39c0f2ea1f53 to 89d864552acd (4 revisions) (flutter/flutter#135169)
2023-09-20 [email protected] [deps] Update package:web dependency. (flutter/flutter#135174)
2023-09-20 [email protected] finer grained logging of Chromium launch sequence (flutter/flutter#135078)
2023-09-20 [email protected] Upgrade AGP version in tracing_tests (flutter/flutter#134671)
2023-09-20 [email protected] Cover cupertino/form_section_test with leak tracing (flutter/flutter#135158)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #7 (flutter/flutter#134943)
2023-09-20 [email protected] Enable strict-inference (flutter/flutter#135043)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #10 (flutter/flutter#135143)
2023-09-20 [email protected] cover more tests with leak tracing (flutter/flutter#134833)
2023-09-20 [email protected] codeisn extension safe iOS framework (flutter/flutter#134966)
2023-09-20 [email protected] Roll Flutter Engine from 6f256257b79f to 55314d08d792 (2 revisions) (flutter/flutter#135151)
2023-09-20 [email protected] Remove 'must be non-null' and 'must not be null' comments in widgets library (flutter/flutter#134992)
2023-09-20 [email protected] Roll Flutter Engine from 5f82fc2f6f24 to 6f256257b79f (1 revision) (flutter/flutter#135147)
2023-09-20 [email protected] [Android] Add Java/AGP/Gradle incompatibility warning to `flutter create` (flutter/flutter#131444)
2023-09-20 [email protected] Roll Packages from d4e2454 to 51e74b9 (12 revisions) (flutter/flutter#135145)
2023-09-20 [email protected] Remove 'must not be null' comments from various libraries. (flutter/flutter#134984)
2023-09-20 [email protected] Roll Flutter Engine from 6535421b30d3 to 5f82fc2f6f24 (2 revisions) (flutter/flutter#135142)
2023-09-20 [email protected] Roll Flutter Engine from 67d4aaef3c7b to 6535421b30d3 (1 revision) (flutter/flutter#135139)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #8 (flutter/flutter#135045)
2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #9 (flutter/flutter#135054)
2023-09-20 [email protected] Roll Flutter Engine from 83b4df415bf3 to 67d4aaef3c7b (1 revision) (flutter/flutter#135128)
2023-09-20 [email protected] Roll Flutter Engine from df4e6c079682 to 83b4df415bf3 (2 revisions) (flutter/flutter#135102)
2023-09-20 [email protected] Roll Flutter Engine from 9c6b2500282b to df4e6c079682 (1 revision) (flutter/flutter#135101)
2023-09-20 [email protected] Roll Flutter Engine from 24f7ac38dfa2 to 9c6b2500282b (3 revisions) (flutter/flutter#135098)
2023-09-20 [email protected] Roll Flutter Engine from 36379b62bec8 to 24f7ac38dfa2 (2 revisions) (flutter/flutter#135096)
2023-09-20 [email protected] Roll Flutter Engine from 81b93fc4a2cc to 36379b62bec8 (2 revisions) (flutter/flutter#135095)
2023-09-20 [email protected] Roll Flutter Engine from 5a924a9017d7 to 81b93fc4a2cc (2 revisions) (flutter/flutter#135093)
2023-09-20 [email protected] Remove 'must be non-null' and 'must not be null' comments from material. (flutter/flutter#134991)
2023-09-20 [email protected] Unpin url launcher (remake) (flutter/flutter#134958)
2023-09-20 [email protected] Roll Flutter Engine from a7af55c56aa6 to 5a924a9017d7 (10 revisions) (flutter/flutter#135085)
2023-09-20 [email protected] Manual roll Flutter Engine from a7af55c56aa6 to 0d7db40c27fd (7 revisions) (flutter/flutter#135079)
2023-09-20 [email protected] Remove 'must not be null' comments from painting and rendering libraries. (flutter/flutter#134993)
2023-09-20 [email protected] cover more tests with leak tracking (flutter/flutter#134837)
2023-09-20 [email protected] [flutter roll] Revert "Native assets support for Linux" (flutter/flutter#135069)
2023-09-20 [email protected] Manual roll Flutter Engine from 10c480310926 to a7af55c56aa6 (4 revisions) (flutter/flutter#135071)
2023-09-19 [email protected] Retry Linux web tests 1 time on roll presubmit (flutter/flutter#135073)
2023-09-19 [email protected] [web] Encode AssetManifest.bin as JSON and use that on the web. (flutter/flutter#131382)
2023-09-19 [email protected] Specify suggested format in doc comment. (flutter/flutter#134887)
2023-09-19 [email protected] Manual roll Flutter Engine from 28f14e6eec4f to 10c480310926 (6 revisions) (flutter/flutter#135066)
...
@HansMuller HansMuller mentioned this pull request Sep 28, 2023
Closed
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@ksokolovskyi @Mairramer
Cover more test/widgets tests with leak tracking flutter#9 (flutter#1…
32e9923 
…35054)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
c3db020 Cover more test/widgets tests with leak tracking flutter#9 (f…
c36c6ce 
…lutter/flutter#135054)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ksokolovskyi @polina-c