Skip to content

Add --frontend-server-starter-path option to flutter run and flutter test #135038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derekxu16 merged 2 commits into from
Sep 21, 2023
Merged

Add --frontend-server-starter-path option to flutter run and flutter test #135038

derekxu16 merged 2 commits into from
Sep 21, 2023

Conversation

@derekxu16
Copy link
Contributor

@derekxu16 derekxu16 commented Sep 19, 2023

No description provided.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 19, 2023
@derekxu16 derekxu16 force-pushed the frontend-server-starter-path branch from 9c5ae44 to bf1e3c1 Compare September 19, 2023 18:50
@derekxu16 derekxu16 force-pushed the frontend-server-starter-path branch from bf1e3c1 to 79a4e64 Compare September 20, 2023 14:07
@derekxu16 derekxu16 marked this pull request as ready for review September 20, 2023 15:43
christopherfujino
christopherfujino reviewed Sep 20, 2023
View reviewed changes
packages/flutter_tools/lib/src/runner/flutter_command.dart
argParser.addOption(
FlutterOptions.kFrontendServerStarterPath,
help: 'When this value is provided, the frontend server will be started '
'in JIT mode from the specified file, instead of from the AOT '
Copy link
Contributor

@christopherfujino christopherfujino Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a dart source entrypoint, a JIT snapshot, or either?

Copy link
Contributor Author

@derekxu16 derekxu16 Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only considering the case of it being a Dart source entrypoint, but you're right that the AppJIT snapshot case is also supported. I've updated the help message.

Copy link
Contributor

@christopherfujino christopherfujino Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@derekxu16 derekxu16 changed the title Add --frontend-server-starter-path option Add --frontend-server-starter-path option to flutter run and flutter test Sep 21, 2023
christopherfujino
christopherfujino approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (verified this worked for me locally on linux)

@derekxu16 derekxu16 merged commit c627dbf into flutter:master Sep 21, 2023
@derekxu16 derekxu16 deleted the frontend-server-starter-path branch September 21, 2023 18:32
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
83f267a 
…and `flutter test` (flutter/flutter#135038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
c85bf2b 
…and `flutter test` (flutter/flutter#135038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
42a1e3e 
…and `flutter test` (flutter/flutter#135038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
d932e74 
…and `flutter test` (flutter/flutter#135038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
b7c05c1 
…and `flutter test` (flutter/flutter#135038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
687ce2b 
…and `flutter test` (flutter/flutter#135038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
f68bcb1 
…and `flutter test` (flutter/flutter#135038)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
8af8af9 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
62b16fe 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
5bf8334 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
f27a07b 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
28ea6d7 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
6631682 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
91a7051 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
f378c3b 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
3b3458f 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
d6f9b0c 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
8ee8434 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
271337c 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
ad87fac 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
6f0e2b9 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
8f9e954 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
4efbf31 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
fb89d8d 
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
0c360dd 
…and `flutter test` (flutter/flutter#135038)
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@derekxu16 @Mairramer
Add --frontend-server-starter-path option to flutter run and `flu…
a7bee24 
…tter test` (flutter#135038)
@derekxu16 derekxu16 mentioned this pull request Oct 16, 2023
Closed
13 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
c627dbf Add --frontend-server-starter-path option to flutter run …
f1e05ca 
…and `flutter test` (flutter/flutter#135038)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@derekxu16 @christopherfujino