Remove top MediaQuery padding from modal bottom sheets' child #13497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Dec 12, 2017
| context: context, | ||
| removeTop: true, | ||
| child: new _ModalBottomSheet<T>(route: this), | ||
| ); |
Contributor
There was a problem hiding this comment.
doesn't Scaffold do this already?
Member
Author
There was a problem hiding this comment.
That's how I missed it too :S
Scaffolds handled persistent bottom sheets. This is a modal bottom sheet that's just a newly pushed PopupRoute.
xster
force-pushed
the
modal-bottom-sheet
branch
from
4cef5f8 to
80c50cd
Compare
cbracken
approved these changes
Dec 12, 2017
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed one from #13438. For #13408.
Also fix dialog_test. It wasn't really testing anything before.