Roll Flutter Engine from e1c784e3f841 to a55da8279022 (4 revisions) #134964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks and code sign them (flutter/engine#45781)
engine-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
Sep 18, 2023
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/134964, due to - The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label. |
8 tasks
Contributor
|
#134966 should fix Mac framework_tests_misc |
engine-flutter-autoroll
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/134964, due to - The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Sep 18, 2023
… and code sign them" (#46004) Reverts #45781 Issue with engine roll flutter/flutter#134964. We need to update the conductor and performa manual roll. We also need to remove the Flutter.framework from the artifact.zip
Contributor
|
Gonna close this to pick up the revert in flutter/engine#46004 |
Contributor
Author
|
Commit queue failed; closing this roll. |
engine-flutter-autoroll
deleted the
flutter-engine-flutter-autoroll-1471df20-3893-47d3-a28f-096af4f82738-1695068008
branch
harryterkelsen
pushed a commit
to flutter/engine
that referenced
this pull request
Oct 23, 2023
… and code sign them" (#46004) Reverts #45781 Issue with engine roll flutter/flutter#134964. We need to update the conductor and performa manual roll. We also need to remove the Flutter.framework from the artifact.zip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine@e1c784e...a55da82
2023-09-18 [email protected] Tighten up ImageReaderPlatformViewRenderTarget code (flutter/engine#45889)
2023-09-18 [email protected] [ios] use python script to generate extension safe frameworks and code sign them (flutter/engine#45781)
2023-09-18 [email protected] Bump impeller-cmake to HEAD. (flutter/engine#45953)
2023-09-18 [email protected] [iOS] Remove selectionDidChange call in UndoManager (flutter/engine#45657)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md