Skip to content

Resolve breaking change of adding a method to ChangeNotifier. #134953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 3 commits into from
Sep 18, 2023
Merged

Resolve breaking change of adding a method to ChangeNotifier. #134953

polina-c merged 3 commits into from
Sep 18, 2023

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Sep 18, 2023 •
edited
Loading

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. f: routes Navigator, Router, and related APIs. f: focus Focus traversal, gaining or losing focus labels Sep 18, 2023
@polina-c polina-c changed the title Resolve breaking change. Resolve breaking change of adding method to ChangeNotifier. Sep 18, 2023
@polina-c polina-c requested a review from goderbauer September 18, 2023 17:09
@polina-c polina-c mentioned this pull request Sep 18, 2023
Merged
@polina-c polina-c changed the title Resolve breaking change of adding method to ChangeNotifier. Resolve breaking change of adding a method to ChangeNotifier. Sep 18, 2023
goderbauer
goderbauer approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

goderbauer commented Sep 18, 2023

@polina-c Did the previous change already make it into a release? If so, we likely want to cherry-pick this change into that release.

@goderbauer
Copy link
Member

goderbauer commented Sep 18, 2023

FYI @passsy

@polina-c
Copy link
Contributor Author

polina-c commented Sep 18, 2023

@polina-c Did the previous change already make it into a release? If so, we likely want to cherry-pick this change into that release.

Previous change is in beta 3.15, but not in release. It seems no cherry pick needed.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2023
@passsy
Copy link
Contributor

passsy commented Sep 18, 2023

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@polina-c polina-c merged commit 5c6ef59 into flutter:master Sep 18, 2023
@polina-c
Copy link
Contributor Author

polina-c commented Sep 18, 2023

Google testing passed: cl/566364786

@polina-c polina-c deleted the static-dispatch branch September 18, 2023 22:33
zanderso added a commit that referenced this pull request Sep 18, 2023
@zanderso
Revert "Resolve breaking change of adding a method to ChangeNotifier. (…
1bf043c 
…#134953)"

This reverts commit 5c6ef59.
@zanderso zanderso mentioned this pull request Sep 18, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Sep 18, 2023
@zanderso
Revert "Resolve breaking change of adding a method to ChangeNotifier." (
a9183f6 
#134978)

Reverts #134953

Several failures on CI
@polina-c polina-c restored the static-dispatch branch September 18, 2023 23:33
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
5c6ef59 Resolve breaking change of adding a method to ChangeNotifier. (…
f1cb6e7 
…flutter/flutter#134953)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
Roll Flutter from b7d0e8c to 8936504 (15 revisions) (#4947)
59febcd 
flutter/flutter@b7d0e8c...8936504

2023-09-19 [email protected] Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998)
2023-09-19 [email protected] Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983)
2023-09-18 [email protected] Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978)
2023-09-18 [email protected] Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953)
2023-09-18 [email protected] Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954)
2023-09-18 [email protected] Access to fragment in router state on page refresh (flutter/flutter#131123)
2023-09-18 [email protected] Enable private field promotion for framework (flutter/flutter#134473)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #6 (flutter/flutter#134884)
2023-09-18 [email protected] Cover more tests with leak tracking. (flutter/flutter#134805)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #5 (flutter/flutter#134869)
2023-09-18 [email protected] Don't uninstall before retrying to connect during app launch (flutter/flutter#134542)
2023-09-18 [email protected] [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955)
2023-09-18 [email protected] Fix memory leak in _DarwinViewState. (flutter/flutter#134938)
2023-09-18 [email protected] Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956)
2023-09-18 [email protected] Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Sep 28, 2023
Closed
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@polina-c @Mairramer
Resolve breaking change of adding a method to ChangeNotifier. (flutte…
dc602a1 
…r#134953)
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@zanderso @Mairramer
Revert "Resolve breaking change of adding a method to ChangeNotifier." (
fc4e564 
flutter#134978)

Reverts flutter#134953

Several failures on CI
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
5c6ef59 Resolve breaking change of adding a method to ChangeNotifier. (…
6f0a659 
…flutter/flutter#134953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: focus Focus traversal, gaining or losing focus f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@polina-c @goderbauer @passsy