[Windows_android channels_integration_test] Column -> ListView #134836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 16, 2023
flutter/flutter@72b69f9...e5e36ad 2023-09-16 [email protected] Manual roll Flutter Engine from 326faf1762d6 to 30b7e9ded7a0 (5 revisions) (flutter/flutter#134876) 2023-09-16 [email protected] Manual roll Flutter Engine from 51e643de62aa to 326faf1762d6 (6 revisions) (flutter/flutter#134875) 2023-09-16 [email protected] Manual roll Flutter Engine from d623ecf43c66 to 51e643de62aa (5 revisions) (flutter/flutter#134865) 2023-09-16 [email protected] Manual roll Flutter Engine from c0eaf2633686 to d623ecf43c66 (5 revisions) (flutter/flutter#134861) 2023-09-16 [email protected] Manual roll Flutter Engine from 5aa9db365ed6 to c0eaf2633686 (5 revisions) (flutter/flutter#134860) 2023-09-16 [email protected] Manual roll Flutter Engine from 67dd12f8dfca to 5aa9db365ed6 (5 revisions) (flutter/flutter#134856) 2023-09-16 [email protected] Roll Flutter Engine from 45bc4307cda3 to 67dd12f8dfca (6 revisions) (flutter/flutter#134791) 2023-09-15 [email protected] Makes scheme and target optional parameter when getting universal lin� (flutter/flutter#134571) 2023-09-15 [email protected] Dispose layers in test. (flutter/flutter#134802) 2023-09-15 [email protected] [Windows_android channels_integration_test] Column -> ListView (flutter/flutter#134836) 2023-09-15 [email protected] moved hello_world_impeller to a 7pro (flutter/flutter#134830) 2023-09-15 [email protected] Speed up native assets target (flutter/flutter#134523) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…er#134836) This should fix flutter#134636. The column can get really tall, especially when there's line wrapping. This is the layout on a tablet, so on a motor g4 this column is likely going to overflow. ``` RenderParagraph#66251 relayoutBoundary=up3 â�� creator: RichText â�� Text-[<'status'>] â�� Column â�� â�� FutureBuilder<TestStepResult> â�� Padding â�� â�� KeyedSubtree-[GlobalKey#0f29e] â�� _BodyBuilder â�� MediaQuery â�� â�� LayoutId-[<_ScaffoldSlot.body>] â�� CustomMultiChildLayout â�� â�� _ActionsScope â�� Actions â�� â�¯ | parentData: offset=Offset(0.0, 600.0); flex=null; fit=null ``` 
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #134636.
The column can get really tall, especially when there's line wrapping. This is the layout on a tablet, so on a motor g4 this column is likely going to overflow.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.