Skip to content

Conversation

@ksokolovskyi
Copy link
Contributor

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Marks leaks

Tests

  • Updates implicit_animations_test.dart to use testWidgetsWithLeakTracking;
  • Updates implicit_semantics_test.dart to use testWidgetsWithLeakTracking;
  • Updates inherited_dependencies_test.dart to use testWidgetsWithLeakTracking;
  • Updates inherited_model_test.dart to use testWidgetsWithLeakTracking;
  • Updates inherited_test.dart to use testWidgetsWithLeakTracking;
  • Updates inherited_theme_test.dart to use testWidgetsWithLeakTracking;
  • Updates init_state_test.dart to use testWidgetsWithLeakTracking;
  • Updates interactive_viewer_test.dart to use testWidgetsWithLeakTracking;
  • Updates intrinsic_width_test.dart to use testWidgetsWithLeakTracking;
  • Updates invert_colors_test.dart to use testWidgetsWithLeakTracking;
  • Updates keep_alive_test.dart to use testWidgetsWithLeakTracking;
  • Updates key_test.dart to use testWidgetsWithLeakTracking;
  • Updates keyboard_listener_test.dart to use testWidgetsWithLeakTracking;
  • Updates layout_builder_and_global_keys_test.dart to use testWidgetsWithLeakTracking;
  • Updates layout_builder_and_parent_data_test.dart to use testWidgetsWithLeakTracking;
  • Updates layout_builder_and_state_test.dart to use testWidgetsWithLeakTracking;
  • Updates layout_builder_mutations_test.dart to use testWidgetsWithLeakTracking;
  • Updates layout_builder_test.dart to use testWidgetsWithLeakTracking;
  • Updates linked_scroll_view_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_body_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_view_builder_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_view_correction_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_view_fling_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_view_horizontal_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_view_misc_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_view_relayout_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_view_semantics_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_view_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_view_vertical_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_view_viewporting_test.dart to use testWidgetsWithLeakTracking;
  • Updates list_view_with_inherited_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. labels Sep 13, 2023
@ksokolovskyi
Copy link
Contributor Author

cc @polina-c

Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksokolovskyi
Copy link
Contributor Author

@polina-c thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants