Cover more test/widgets tests with leak tracking #3 #134576

ksokolovskyi · 2023-09-12T20:15:17Z

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Marks leaks

Memory Leak: TestClipPaintingContext does not dispose ContainerLayer #134572
Memory Leak: RenderSliverEdgeInsetsPadding does not dispose OffsetLayer when testing with TestClipPaintingContext #134575

Tests

Updates form_test.dart to use testWidgetsWithLeakTracking;
Updates fractionally_sized_box_test.dart to use testWidgetsWithLeakTracking;
Updates framework_test.dart to use testWidgetsWithLeakTracking;
Updates gesture_detector_semantics_test.dart to use testWidgetsWithLeakTracking;
Updates gesture_detector_test.dart to use testWidgetsWithLeakTracking;
Updates gesture_disambiguation_test.dart to use testWidgetsWithLeakTracking;
Updates global_keys_duplicated_test.dart to use testWidgetsWithLeakTracking;
Updates global_keys_moving_test.dart to use testWidgetsWithLeakTracking;
Updates grid_paper_test.dart to use testWidgetsWithLeakTracking;
Updates grid_view_layout_test.dart to use testWidgetsWithLeakTracking;
Updates grid_view_test.dart to use testWidgetsWithLeakTracking;
Updates heroes_test.dart to use testWidgetsWithLeakTracking;
Updates hit_testing_test.dart to use testWidgetsWithLeakTracking;
Updates hyperlink_test.dart to use testWidgetsWithLeakTracking;
Updates icon_test.dart to use testWidgetsWithLeakTracking;
Updates image_filter_quality_test.dart to use testWidgetsWithLeakTracking;
Updates image_filter_test.dart to use testWidgetsWithLeakTracking;
Updates image_headers_test.dart to use testWidgetsWithLeakTracking;
Updates image_icon_test.dart to use testWidgetsWithLeakTracking;
Updates image_resolution_test.dart to use testWidgetsWithLeakTracking;
Updates image_rtl_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

ksokolovskyi · 2023-09-12T20:16:24Z

cc @polina-c

packages/flutter/test/widgets/grid_view_test.dart

polina-c

couple small comments

ksokolovskyi · 2023-09-13T14:17:34Z

@polina-c thanks for the review.

ksokolovskyi · 2023-09-13T14:21:01Z

@polina-c, what to do if it happens that there is the same leak in a couple of testWidgetsWithLeakTracking?
Do I need to mark the leak in only one of them and revert all others to the testWidgets, or do I need to mark all the tests?

polina-c · 2023-09-14T18:40:01Z

@polina-c, what to do if it happens that there is the same leak in a couple of testWidgetsWithLeakTracking? Do I need to mark the leak in only one of them and revert all others to the testWidgets, or do I need to mark all the tests?

Thanks for asking. I will add answer to top description of the main issue. Let's convert just one test. It will be enough for issue resolution. When we have too many issues, we need to stop conversion and fix them, before going forward.

polina-c

LGTM

auto-submit · 2023-09-14T18:46:57Z

auto label is removed for flutter/flutter/134576, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

ksokolovskyi · 2023-09-14T20:17:27Z

@polina-c, what to do if it happens that there is the same leak in a couple of testWidgetsWithLeakTracking? Do I need to mark the leak in only one of them and revert all others to the testWidgets, or do I need to mark all the tests?

Thanks for asking. I will add answer to top description of the main issue. Let's convert just one test. It will be enough for issue resolution. When we have too many issues, we need to stop conversion and fix them, before going forward.

Thanks a lot for the answer and review!

…lutter/flutter#134576)

flutter/flutter@58ba6c2...72b69f9 2023-09-15 [email protected] Date picker dialog state should dispose members. (flutter/flutter#134804) 2023-09-15 [email protected] Roll Packages from 275b76c to bc8c2f2 (7 revisions) (flutter/flutter#134823) 2023-09-15 [email protected] Fix navigation rail hover misplaced when direction is RTL and extended is true (flutter/flutter#134815) 2023-09-15 [email protected] Applied the logo to the Discord badge. (flutter/flutter#134339) 2023-09-15 [email protected] Fix memory leak in ListWheelScrollView (flutter/flutter#134732) 2023-09-15 [email protected] Move two tests on Pixel 7 from staging to prod (flutter/flutter#134784) 2023-09-14 [email protected] Roll Flutter Engine from 683bca53d4d7 to 45bc4307cda3 (2 revisions) (flutter/flutter#134789) 2023-09-14 [email protected] [web] provide serviceWorkerVersion to the getNewServiceWorker function (flutter/flutter#131240) 2023-09-14 [email protected] Roll Flutter Engine from 3a3a2807c3b6 to 683bca53d4d7 (3 revisions) (flutter/flutter#134778) 2023-09-14 [email protected] Roll Flutter Engine from 035932d64017 to 3a3a2807c3b6 (5 revisions) (flutter/flutter#134769) 2023-09-14 [email protected] Allows page removal that contains Localhistoryentry (flutter/flutter#134757) 2023-09-14 [email protected] Roll Flutter Engine from e0b5b6c4eb76 to 035932d64017 (2 revisions) (flutter/flutter#134763) 2023-09-14 [email protected] Cover more test/widgets tests with leak tracking #3 (flutter/flutter#134576) 2023-09-14 [email protected] Roll Flutter Engine from 2cd34d23c1a2 to e0b5b6c4eb76 (2 revisions) (flutter/flutter#134755) 2023-09-14 [email protected] Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (flutter/flutter#134693) 2023-09-14 [email protected] Cover some Services tests with leak tracing (flutter/flutter#134381) 2023-09-14 [email protected] Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (flutter/flutter#134749) 2023-09-14 [email protected] ð�� Setup color tween for `RefreshIndicator` in a better way (flutter/flutter#134492) 2023-09-14 [email protected] Fix NavigationRail hover misplaced when using large icons (flutter/flutter#134719) 2023-09-14 [email protected] Roll Flutter Engine from cd90cc8469fb to 4160ebacdae2 (5 revisions) (flutter/flutter#134695) 2023-09-14 [email protected] Added a devicelab test for vulkan validation layers (flutter/flutter#134685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter/flutter#134576)

Update more test/widget tests

8ceb8a4

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Sep 12, 2023

This was referenced Sep 12, 2023

Memory Leak: TestClipPaintingContext does not dispose ContainerLayer #134572

Closed

Memory Leak: RenderSliverEdgeInsetsPadding does not dispose OffsetLayer when testing with TestClipPaintingContext #134575

Closed

goderbauer requested a review from polina-c September 12, 2023 22:02

polina-c reviewed Sep 12, 2023

View reviewed changes

packages/flutter/test/widgets/grid_view_test.dart Outdated Show resolved Hide resolved

polina-c reviewed Sep 12, 2023

View reviewed changes

packages/flutter/test/widgets/grid_view_test.dart Outdated Show resolved Hide resolved

polina-c reviewed Sep 12, 2023

View reviewed changes

polina-c and others added 3 commits September 12, 2023 15:11

Merge branch 'master' into leak-tracking-tests-3

a746432

Merge branch 'master' into leak-tracking-tests-3

e416ba1

Fix someone

6d6548f

ksokolovskyi requested a review from polina-c September 13, 2023 14:17

ksokolovskyi changed the title ~~Cover more test/widgets tests with leak tracking~~ Cover more test/widgets tests with leak tracking #3 Sep 13, 2023

polina-c approved these changes Sep 14, 2023

View reviewed changes

polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023

polina-c merged commit ff10c52 into flutter:master Sep 14, 2023

engine-flutter-autoroll mentioned this pull request Sep 15, 2023

Roll Flutter from 58ba6c295d8c to 0b540a87f1be (18 revisions) flutter/packages#4932

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2023

ff10c52 Cover more test/widgets tests with leak tracking flutter#3 (f…

64fccac

…lutter/flutter#134576)

engine-flutter-autoroll mentioned this pull request Sep 15, 2023

Roll Flutter from 58ba6c295d8c to 2a7ad01e559c (19 revisions) flutter/packages#4933

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2023

ff10c52 Cover more test/widgets tests with leak tracking flutter#3 (f…

a2172c9

…lutter/flutter#134576)

engine-flutter-autoroll mentioned this pull request Sep 15, 2023

Roll Flutter from 58ba6c295d8c to 72b69f944915 (21 revisions) flutter/packages#4934

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2023

ff10c52 Cover more test/widgets tests with leak tracking flutter#3 (f…

9298c76

…lutter/flutter#134576)

HansMuller mentioned this pull request Sep 15, 2023

Flutter Framework Team: Notable Commits #121415

Closed

Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023

Cover more test/widgets tests with leak tracking #3 (flutter#134576)

a05f576

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

ff10c52 Cover more test/widgets tests with leak tracking flutter#3 (f…

352735b

…lutter/flutter#134576)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cover more test/widgets tests with leak tracking #3 #134576

Cover more test/widgets tests with leak tracking #3 #134576

Uh oh!

ksokolovskyi commented Sep 12, 2023

Uh oh!

ksokolovskyi commented Sep 12, 2023

Uh oh!

Uh oh!

Uh oh!

polina-c left a comment

Uh oh!

ksokolovskyi commented Sep 13, 2023

Uh oh!

ksokolovskyi commented Sep 13, 2023

Uh oh!

polina-c commented Sep 14, 2023 •

edited

Loading

Uh oh!

polina-c left a comment

Uh oh!

auto-submit bot commented Sep 14, 2023

Uh oh!

ksokolovskyi commented Sep 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Cover more test/widgets tests with leak tracking #3 #134576

Cover more test/widgets tests with leak tracking #3 #134576

Uh oh!

Conversation

ksokolovskyi commented Sep 12, 2023

Description

Marks leaks

Tests

Pre-launch Checklist

Uh oh!

ksokolovskyi commented Sep 12, 2023

Uh oh!

Uh oh!

Uh oh!

polina-c left a comment

Choose a reason for hiding this comment

Uh oh!

ksokolovskyi commented Sep 13, 2023

Uh oh!

ksokolovskyi commented Sep 13, 2023

Uh oh!

polina-c commented Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

polina-c left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Sep 14, 2023

Uh oh!

ksokolovskyi commented Sep 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

polina-c commented Sep 14, 2023 •

edited

Loading