Skip to content

Update BottomSheetTest #134562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 1 commit into from
Sep 13, 2023
Merged

Update BottomSheetTest #134562

polina-c merged 1 commit into from
Sep 13, 2023

Conversation

@hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented Sep 12, 2023 •
edited
Loading

fixes: #133594

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 12, 2023
@hannah-hyj hannah-hyj changed the title [draft] Update BottomSheetTest Update BottomSheetTest Sep 12, 2023
@hannah-hyj hannah-hyj requested a review from polina-c September 12, 2023 20:35
@polina-c polina-c mentioned this pull request Sep 13, 2023
Closed
@polina-c polina-c merged commit 6c7ddb8 into flutter:master Sep 13, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
6c7ddb8 Update BottomSheetTest (flutter/flutter#134562)
7543b6f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
6c7ddb8 Update BottomSheetTest (flutter/flutter#134562)
a559065
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
6c7ddb8 Update BottomSheetTest (flutter/flutter#134562)
cc71dc0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
6c7ddb8 Update BottomSheetTest (flutter/flutter#134562)
340b624
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
6c7ddb8 Update BottomSheetTest (flutter/flutter#134562)
bbee1c6
@HansMuller HansMuller mentioned this pull request Sep 15, 2023
Closed
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@hannah-hyj @Mairramer
Update BottomSheetTest (flutter#134562)
2b04c1d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
6c7ddb8 Update BottomSheetTest (flutter/flutter#134562)
ee7af75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

showModalBottomSheet creates ModalBottomSheetRoute that is never disposed.

2 participants

@hannah-hyj @polina-c