Skip to content

Conversation

@zanderso
Copy link
Member

A flake in this shard caused an engine roll to fail here #134526

@zanderso zanderso requested review from bdero and keyonghan September 12, 2023 16:52
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 12, 2023

auto label is removed for flutter/flutter/134552, due to - The status or check suite Windows tool_integration_tests_4_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 12, 2023

auto label is removed for flutter/flutter/134552, due to - The status or check suite Linux web_canvaskit_tests_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso zanderso changed the title Retry Linux web_canvaskit_tests_5 1 time on roll presubmit Retry Linux web tests 1 time on roll presubmit Sep 12, 2023
@zanderso
Copy link
Member Author

Some web tests flaked on this PR, so I added this in more places.

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@keyonghan
Copy link
Contributor

keyonghan commented Sep 12, 2023

The auto rerun fails due to #134560. Please hold a bit landing this PR. I will update here if issue resolves.

@auto-submit auto-submit bot merged commit 64c1223 into master Sep 12, 2023
@auto-submit auto-submit bot deleted the zanderso-patch-2 branch September 12, 2023 18:29
keyonghan added a commit that referenced this pull request Sep 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants