Roll Flutter Engine from 0774ddcda9b0 to d671b2d3e43a (2 revisions) #134455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
Sep 11, 2023
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/134455, due to - The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
zanderso
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/134455, due to - The status or check suite Linux web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
Commit queue failed; closing this roll. |
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Sep 11, 2023
…tter APIs." (#45660) Reverts #45591 This is somehow causing some issues with the hot reload tests and blocking engine -> framework rolls. See flutter/flutter#134455
engine-flutter-autoroll
deleted the
flutter-engine-flutter-autoroll-c5af7297-2798-4cbc-82b6-046fe72a4497-1694459805
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine@0774ddc...d671b2d
2023-09-11 [email protected] Update skwasm build to use safer flush call (flutter/engine#45652)
2023-09-11 [email protected] Remove some of our hacks around JSPromise now that we have better APIs. (flutter/engine#45591)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md