Skip to content

Cover more test/widgets tests with leak tracking #2 #134387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 15 commits into from
Sep 13, 2023
Merged

Cover more test/widgets tests with leak tracking #2 #134387

polina-c merged 15 commits into from
Sep 13, 2023

Conversation

@ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented Sep 10, 2023 •
edited
Loading

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Marks leaks

Tests

  • Updates draggable_test.dart to use testWidgetsWithLeakTracking;
  • Updates drawer_test.dart to use testWidgetsWithLeakTracking;
  • Updates dual_transition_builder_test.dart to use testWidgetsWithLeakTracking;
  • Updates editable_text_cursor_test.dart to use testWidgetsWithLeakTracking;
  • Updates editable_text_shortcuts_test.dart to use testWidgetsWithLeakTracking;
  • Updates editable_text_show_on_screen_test.dart to use testWidgetsWithLeakTracking;
  • Updates editable_text_test.dart to use testWidgetsWithLeakTracking;
  • Updates ensure_visible_test.dart to use testWidgetsWithLeakTracking;
  • Updates error_widget_builder_test.dart to use testWidgetsWithLeakTracking;
  • Updates fade_in_image_test.dart to use testWidgetsWithLeakTracking;
  • Updates fade_transition_test.dart to use testWidgetsWithLeakTracking;
  • Updates fitted_box_test.dart to use testWidgetsWithLeakTracking;
  • Updates flex_test.dart to use testWidgetsWithLeakTracking;
  • Updates flow_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Sep 10, 2023
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 10, 2023

cc @polina-c

@ksokolovskyi ksokolovskyi mentioned this pull request Sep 10, 2023
Closed
2 tasks
polina-c
polina-c reviewed Sep 10, 2023
View reviewed changes
polina-c
polina-c requested changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Couple comments.

polina-c
polina-c reviewed Sep 10, 2023
View reviewed changes
polina-c
polina-c requested changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more comments.

@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 10, 2023

@polina-c I live in the CET timezone, so I will continue to work on this PR tomorrow (Monday).

@polina-c polina-c mentioned this pull request Sep 11, 2023
Closed
polina-c
polina-c reviewed Sep 11, 2023
View reviewed changes
@polina-c
Copy link
Contributor

polina-c commented Sep 11, 2023

@ksokolovskyi , is it ready for next round of review?

@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 12, 2023

@polina-c yes, could you please take a look again?

@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Sep 12, 2023

@polina-c thanks a lot for your attentiveness!

polina-c
polina-c approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c requested a review from chunhtai September 12, 2023 21:56
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 12, 2023

auto label is removed for flutter/flutter/134387, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

chunhtai
chunhtai approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 12, 2023

auto label is removed for flutter/flutter/134387, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 12, 2023

auto label is removed for flutter/flutter/134387, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c merged commit 7d0c9b7 into flutter:master Sep 13, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…
d6abc11 
…tter#134387)
@ksokolovskyi ksokolovskyi changed the title Cover more test/widgets tests with leak tracking Cover more test/widgets tests with leak tracking #2 Sep 13, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…
8866854 
…tter#134387)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…
3fb3cac 
…tter#134387)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…
88866be 
…tter#134387)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…
99f0b86 
…tter#134387)
@HansMuller HansMuller mentioned this pull request Sep 15, 2023
Closed
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@ksokolovskyi @Mairramer
Cover more test/widgets tests with leak tracking (flutter#134387)
a0f6593
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…
1ae2f66 
…tter#134387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ksokolovskyi @polina-c @chunhtai @XilaiZhang