Remove dangling MediaQuery paddings for non-fullscreen dialogs - 2 #13438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the edge of the screen
gspencergoog
approved these changes
Dec 8, 2017
Contributor
|
LGTM |
…. Add test for others.
Member
Author
|
Removed handling from bottom sheet. The scaffold already handles it. Added more tests |
This was referenced Dec 8, 2017
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
…lutter#13438) * Remove MediaQuery padding for various PopupRoutes that don't extend to the edge of the screen * bottom sheet doesn't actually need handling. Scaffold does it already. Add test for others.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13408
Alternate approach to #13436 for customizable edges in case dialogs hug the screen on some sides.
Removes dangling paddings for sides that don't intersect with the partial obstructions.