Scaffold resizeToAvoidBottomPadding uses view insets #13437
Conversation
xster
left a comment
xster
left a comment
There was a problem hiding this comment.
Do we need some logic to not show the bottom bar when inset != 0 or is that a different PR?
There was a problem hiding this comment.
also test that a mediaquery with a padding doesn't mess with the scaffold layout in unexpected ways?
There was a problem hiding this comment.
And maybe that both can exist and still works ok
There was a problem hiding this comment.
Should be covered by the last test (line 553ish). I'm okay with adding it on the others for backup though -- wdyt?
cbracken
force-pushed
the
viewinsets-only
branch
from
a97e7da to
a9ff4ef
Compare
That's new behaviour, so I'll follow up with that in a separate CL. Probably worth adding a tab with a TextField to the gallery bottom nav demo when I do that. |
Now that keyboard height is modeled as a (bottom) view inset, migrate scaffold bottom resizing to use view insets instead of bottom padding, which, after an engine roll, will only be used for safe areas. Until the aforementioned engine roll, the keyboard height is still included in both bottom padding and view insets. As such resizeToAvoidBottomPadding still drives bottom padding removal until that roll lands.
cbracken
force-pushed
the
viewinsets-only
branch
from
a9ff4ef to
cf07833
Compare
Now that keyboard height is modelled as a (bottom) view inset, migrate scaffold bottom resizing to use view insets instead of bottom padding, which, after an engine roll, will only be used for safe areas. Until the aforementioned engine roll, the keyboard height is still included in both bottom padding and view insets. As such resizeToAvoidBottomPadding still drives bottom padding removal until that roll lands. Renames _ScaffoldLayout.bottomPadding to bottomViewInset
3 participants
Now that keyboard height is modeled as a (bottom) view inset, migrate
scaffold bottom resizing to use view insets instead of bottom padding,
which, after an engine roll, will only be used for safe areas.
Until the aforementioned engine roll, the keyboard height is still
included in both bottom padding and view insets. As such
resizeToAvoidBottomPadding still drives bottom padding removal until
that roll lands.