Skip to content

Conversation

@huycozy
Copy link
Member

@huycozy huycozy commented Sep 5, 2023

Closes #119921

Demo

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@huycozy huycozy self-assigned this Sep 5, 2023
@huycozy huycozy force-pushed the perf-speed-issue-template branch from c4c9051 to b608817 Compare September 6, 2023 03:40
@huycozy
Copy link
Member Author

huycozy commented Sep 12, 2023

Thanks for your comments. Demo of the changes I pushed:

Issue: My app is slow or missing frames

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@huycozy huycozy force-pushed the perf-speed-issue-template branch from eb3db97 to 7936e69 Compare September 18, 2023 16:03
@huycozy huycozy added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Sep 18, 2023
… template to use Github forms

Signed-off-by: Nguyen Huy <[email protected]>
@huycozy huycozy force-pushed the perf-speed-issue-template branch from 7936e69 to f285650 Compare September 18, 2023 16:10
@huycozy huycozy added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2023
@auto-submit auto-submit bot merged commit b195c94 into flutter:master Sep 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 19, 2023
flutter/flutter@b7d0e8c...8936504

2023-09-19 [email protected] Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998)
2023-09-19 [email protected] Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983)
2023-09-18 [email protected] Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978)
2023-09-18 [email protected] Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953)
2023-09-18 [email protected] Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954)
2023-09-18 [email protected] Access to fragment in router state on page refresh (flutter/flutter#131123)
2023-09-18 [email protected] Enable private field promotion for framework (flutter/flutter#134473)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #6 (flutter/flutter#134884)
2023-09-18 [email protected] Cover more tests with leak tracking. (flutter/flutter#134805)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #5 (flutter/flutter#134869)
2023-09-18 [email protected] Don't uninstall before retrying to connect during app launch (flutter/flutter#134542)
2023-09-18 [email protected] [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955)
2023-09-18 [email protected] Fix memory leak in _DarwinViewState. (flutter/flutter#134938)
2023-09-18 [email protected] Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956)
2023-09-18 [email protected] Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@bleroux bleroux deleted the perf-speed-issue-template branch March 6, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate the "Missing frames / speed related performance issues" issue template to use Github forms

2 participants