Skip to content

CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor. #133918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 3 commits into from
Sep 5, 2023
Merged

CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor. #133918

polina-c merged 3 commits into from
Sep 5, 2023

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Sep 2, 2023

Fixes #133912

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels Sep 2, 2023
@polina-c polina-c mentioned this pull request Sep 2, 2023
Closed
chunhtai
chunhtai approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit 7cdf314 into flutter:master Sep 5, 2023
@polina-c polina-c deleted the ScrollController-fix branch September 5, 2023 20:01
polina-c added a commit that referenced this pull request Sep 5, 2023
@polina-c
Revert "CupertinoAlertDialog should not create ScrollController on ev…
772c00e 
…ery build, if null values are passed in constructor. (#133918)"

This reverts commit 7cdf314.
@polina-c polina-c mentioned this pull request Sep 5, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Sep 5, 2023
@polina-c
Revert "CupertinoAlertDialog should not create ScrollController on ev…
a425e56 
…ery build, if null values are passed in constructor." (#134071)

Reverts #133918 as it causes build failures.
@polina-c polina-c restored the ScrollController-fix branch September 5, 2023 21:22
@polina-c polina-c mentioned this pull request Sep 5, 2023
Merged
2 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
ef8bc84 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
836e991 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
2892663 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
2f4f2f6 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
d5944c2 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
9a18876 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
4cd52ad 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
fb85ae9 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
f512cd5 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
fc463b7 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
ffa7b57 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
3754ddb 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
1f67025 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
74781c3 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
@HansMuller HansMuller mentioned this pull request Sep 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
7cdf314 CupertinoAlertDialog should not create ScrollController on ev…
81e96cb 
…ery build, if null values are passed in constructor. (flutter/flutter#133918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor.

2 participants

@polina-c @chunhtai