Skip to content

RenderParagraph should dispose instances of SelectableFragments. #133915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 5 commits into from
Sep 5, 2023
Merged

RenderParagraph should dispose instances of SelectableFragments. #133915

polina-c merged 5 commits into from
Sep 5, 2023

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Sep 2, 2023

No description provided.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 2, 2023
@polina-c polina-c mentioned this pull request Sep 2, 2023
Closed
Renzo-Olivares
Renzo-Olivares reviewed Sep 4, 2023
View reviewed changes
Renzo-Olivares
Renzo-Olivares approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small nit.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 4, 2023

auto label is removed for flutter/flutter/133915, due to - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Renzo-Olivares
Renzo-Olivares reviewed Sep 4, 2023
View reviewed changes
packages/flutter/lib/src/rendering/paragraph.dart Outdated
_disposeSelectableFragments();
// _lastSelectableFragments may hold references to this RenderParagraph.
// Release them manually to avoid retain cycles.
_lastSelectableFragments = null;
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares Sep 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this line (443) and put _disposeSelectableFragments under the comment since it already nulls _lastSelectableFragments.

Copy link
Contributor Author

@polina-c polina-c Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Thank you.

Copy link
Contributor Author

@polina-c polina-c Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think the comment is relevant any more.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2023
@polina-c polina-c merged commit af1b749 into flutter:master Sep 5, 2023
@polina-c polina-c deleted the RenderParagraph branch September 5, 2023 20:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
9ba8e3c 
…ts. (flutter/flutter#133915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
fe5283a 
…ts. (flutter/flutter#133915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
a59d425 
…ts. (flutter/flutter#133915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
b3095ba 
…ts. (flutter/flutter#133915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
ec97080 
…ts. (flutter/flutter#133915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
64e03cc 
…ts. (flutter/flutter#133915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
329b9cf 
…ts. (flutter/flutter#133915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
09ca35a 
…ts. (flutter/flutter#133915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
d956968 
…ts. (flutter/flutter#133915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
103f00d 
…ts. (flutter/flutter#133915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
7d322f4 
…ts. (flutter/flutter#133915)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
61788f1 
…ts. (flutter/flutter#133915)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
1a0fb1c 
…ts. (flutter/flutter#133915)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
5c5cd26 
…ts. (flutter/flutter#133915)
@HansMuller HansMuller mentioned this pull request Sep 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
af1b749 RenderParagraph should dispose instances of SelectableFragmen…
fce4275 
…ts. (flutter/flutter#133915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @Renzo-Olivares