Skip to content

[Windows Arm64] Add first device lab test #133895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Sep 1, 2023
Merged

[Windows Arm64] Add first device lab test #133895

auto-submit merged 1 commit into from
Sep 1, 2023

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Sep 1, 2023 •
edited
Loading

Adds the first Windows Arm64 devicelab test. The builder for this test won't be created until after this lands on master, so we can't actually test this until this is merged.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing. We can't test this new builder until it lands to master.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

christopherfujino
christopherfujino approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as we can't verify the correctness until AFTER the configuration has been written post-submit.

@loic-sharma loic-sharma marked this pull request as ready for review September 1, 2023 23:40
@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit auto-submit bot merged commit df8ee8d into flutter:master Sep 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
8b60f8f 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
0204cc7 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
c17a489 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
f763220 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
a96d723 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
85740be 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
6ef2e45 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
700323a 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
55f8170 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
4379abf 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
71fb9f9 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
f7dfcf7 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
368f09d 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
e9b9113 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
de92b81 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
c26d339 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
d55cdc1 
…3895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
561835a 
…3895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
f76b6e2 
…3895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
cfb4d7c 
…3895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
8a58b6c 
…3895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
98dbb02 
…3895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
5426826 
…3895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
df8ee8d [Windows Arm64] Add first device lab test (flutter/flutter#13…
19364a5 
…3895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loic-sharma @christopherfujino