Skip to content

[CP] Migrate web-only initialization APIs #133891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 6, 2023
Merged

[CP] Migrate web-only initialization APIs #133891

auto-submit merged 2 commits into from
Sep 6, 2023

Conversation

@ditman
Copy link
Member

@ditman ditman commented Sep 1, 2023 •
edited
Loading

This CP lands PR #129856 into stable.

The PR above was part of a engine+framework change that got split in half during the stable cut, so now users are seeing some warnings that they can't act on.

(Those warnings were only intended for people who were using our methods manually, rather than using normal flutter tooling).

Issues

Fixes #133069

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@mdebbar @ditman
[web] Migrate web-only initialization APIs (flutter#129856)
0e9ea77 
- `ui_web.warmupEngine`
- `ui_web.setPluginHandler`
- `ui_web.debugEmulateFlutterTesterEnvironment`
@ditman ditman requested review from mdebbar and yjbanov September 1, 2023 21:06
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. labels Sep 1, 2023
@ditman ditman mentioned this pull request Sep 1, 2023
Closed
@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 6, 2023
@auto-submit auto-submit bot merged commit ad5235b into flutter:flutter-3.13-candidate.0 Sep 6, 2023
@ditman ditman mentioned this pull request Sep 6, 2023
Closed
2 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
ad5235b4e [CP] Migrate web-only initialization APIs (flutter/flutter#…
2483163 
…133891)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

@mdebbar mdebbar Awaiting requested review from mdebbar

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ditman @yjbanov @itsjustkevin @mdebbar