Skip to content

RestorableProperty should dispatch creation in constructor. #133883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 3 commits into from
Sep 2, 2023
Merged

RestorableProperty should dispatch creation in constructor. #133883

polina-c merged 3 commits into from
Sep 2, 2023

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Sep 1, 2023

No description provided.

@polina-c polina-c requested a review from goderbauer September 1, 2023 18:41
@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 1, 2023
@polina-c polina-c requested a review from chunhtai September 1, 2023 18:44
chunhtai
chunhtai approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the f: material design flutter/packages/flutter/material repository. label Sep 2, 2023
@polina-c polina-c added autosubmit Merge PR when tree becomes green via auto submit App and removed f: material design flutter/packages/flutter/material repository. labels Sep 2, 2023
@polina-c polina-c changed the title RestorableProperty should dispatche creation in constructor. RestorableProperty should dispatch creation in constructor. Sep 2, 2023
@polina-c polina-c mentioned this pull request Sep 2, 2023
Closed
@polina-c polina-c merged commit 248645a into flutter:master Sep 2, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
a59f364 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
ee32006 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
ac099ad 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
98f57d5 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
0de1183 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
110ff91 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
8765915 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
54e94d8 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
3e485ee 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
07f9075 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
17d9cec 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
11f0e82 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
d6f1ba5 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
22e9c25 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
9641476 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
35bde9a 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
863a344 
…lutter/flutter#133883)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
6c3b611 
…lutter/flutter#133883)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
0905b35 
…lutter/flutter#133883)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
52438d2 
…lutter/flutter#133883)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
425b21d 
…lutter/flutter#133883)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
fb76441 
…lutter/flutter#133883)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
6190572 
…lutter/flutter#133883)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
248645a RestorableProperty should dispatch creation in constructor. (f…
8367112 
…lutter/flutter#133883)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @chunhtai