Skip to content

MaterialStatesController should dispatch creation in constructor. #133826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 8 commits into from
Sep 2, 2023
Merged

MaterialStatesController should dispatch creation in constructor. #133826

polina-c merged 8 commits into from
Sep 2, 2023

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Sep 1, 2023 •
edited
Loading

This PR also updates other tests to use matcher.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 1, 2023
@github-actions github-actions bot added the f: focus Focus traversal, gaining or losing focus label Sep 1, 2023
@github-actions github-actions bot added f: scrolling Viewports, list views, slivers, etc. f: routes Navigator, Router, and related APIs. labels Sep 1, 2023
@polina-c polina-c requested a review from chunhtai September 1, 2023 01:01
@polina-c polina-c marked this pull request as ready for review September 1, 2023 01:02
@polina-c polina-c mentioned this pull request Sep 1, 2023
Closed
@polina-c polina-c requested a review from goderbauer September 1, 2023 18:03
chunhtai
chunhtai approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor question

packages/flutter/lib/src/material/material_state.dart Outdated
/// Creates a MaterialStatesController.
MaterialStatesController([Set<MaterialState>? value]) : super(<MaterialState>{...?value});
MaterialStatesController([Set<MaterialState>? value]) : super(<MaterialState>{...?value}) {
if (kFlutterMemoryAllocationsEnabled) {
Copy link
Contributor

@chunhtai chunhtai Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought super should have called this?

Copy link
Contributor Author

@polina-c polina-c Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, you are right
reverted. thank you!

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@polina-c polina-c merged commit a3362a9 into flutter:master Sep 2, 2023
@polina-c polina-c deleted the MaterialStatesController branch September 2, 2023 00:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
23b3004 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
dd36611 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
540a368 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
29b36fc 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
eab1e61 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
578d491 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
44a3ede 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
dcfefa3 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
6c3a44c 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
eb77e31 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
8929566 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
4d3d634 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
2b52773 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
c1e9090 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
707f867 
…tor. (flutter/flutter#133826)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
6a40135 
…tor. (flutter/flutter#133826)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
506ab40 
…tor. (flutter/flutter#133826)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
9f90f47 
…tor. (flutter/flutter#133826)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
63bd8e3 
…tor. (flutter/flutter#133826)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
9f16f1c 
…tor. (flutter/flutter#133826)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
b22a5af 
…tor. (flutter/flutter#133826)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
a3362a9 MaterialStatesController should dispatch creation in construc…
0496463 
…tor. (flutter/flutter#133826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @chunhtai