Skip to content

Fix sample code crash, add test #133812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 31, 2023
Merged

Fix sample code crash, add test #133812

auto-submit merged 1 commit into from
Aug 31, 2023

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 31, 2023 •
edited
Loading

Fixes #133402

On web 1 << 32 crashes, 31 is the maximum.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos c: tech-debt Technical debt, code quality, testing, etc. labels Aug 31, 2023
@Piinks Piinks requested a review from gspencergoog August 31, 2023 22:14
gspencergoog
gspencergoog approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023
gspencergoog
gspencergoog reviewed Aug 31, 2023
View reviewed changes
examples/api/test/widgets/transitions/listenable_builder.3_test.dart
Copy link
Contributor

@gspencergoog gspencergoog Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you added this test, you get to remove it from the list of missing tests!

https://github.com/gspencergoog/flutter/blob/menu_overlay_portal/dev/bots/check_code_samples.dart#L408-L409

Copy link
Contributor Author

@Piinks Piinks Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Another one down! 😀

@auto-submit auto-submit bot merged commit 5b6d748 into flutter:master Aug 31, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
c2c2618
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
29ec584
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
d144d5d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
a47257e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
2854ddf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
83f2711
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
c5f123d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
6fc9bbf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
34c9947
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
5a00dd2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
4868aa7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
1dad536
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
d442592
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
3677e58
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
6615fc5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
7ea9688
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
f158eb2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
3dfedcf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
1e9e7dd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
4311c6e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
949f8b5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
780edf5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
2abe5cc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
1a66544
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
2453b53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
25a8cf2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
46a9d6c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
95170e8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
42d655b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
5b6d748 Fix sample code crash, add test (flutter/flutter#133812)
022ba1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The 2nd example of ChangeNotifier has RangeError with generating a random integer value

2 participants

@Piinks @gspencergoog