Skip to content

Revert "Fixing memory leak in EditableTextState" #133804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 31, 2023
Merged

Revert "Fixing memory leak in EditableTextState" #133804

auto-submit merged 1 commit into from
Aug 31, 2023

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Aug 31, 2023

Reverts #131377

reverting because of internal google testing failures b/298310760

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 31, 2023
@Renzo-Olivares Renzo-Olivares added the revert Autorevert PR (with "Reason for revert:" comment) label Aug 31, 2023
@auto-submit auto-submit bot merged commit acdcbae into master Aug 31, 2023
@auto-submit auto-submit bot deleted the revert-131377-leak-fix branch August 31, 2023 20:42
@Renzo-Olivares Renzo-Olivares mentioned this pull request Aug 31, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
cb69375 
…tter#133804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
90698e2 
…tter#133804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
5ebc66b 
…tter#133804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
3b04ebc 
…tter#133804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
680129a 
…tter#133804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
5d529ad 
…tter#133804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
878eb1b 
…tter#133804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
4c61ea7 
…tter#133804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
42d61f3 
…tter#133804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
7165d5a 
…tter#133804)
auto-submit bot pushed a commit that referenced this pull request Sep 3, 2023
@Renzo-Olivares
Reland leak fix for EditableTextState (#133806)
ef9befc 
Relands: #131377
Reverted in: #133804
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
76d539e 
…tter#133804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
e3fa57d 
…tter#133804)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
a0a8216 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
2168561 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
b025120 
…tter#133804)
@Jasguerrero Jasguerrero mentioned this pull request Sep 5, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
7ec18ec 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
d66ab10 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
39b56d8 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
528101f 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
5af4470 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
d071fdb 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
9473aa7 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
1ba536d 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
f9b8306 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
32a8d05 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
cb71042 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
5011c42 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
a256554 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
e5756d2 
…tter#133804)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
acdcbae Revert "Fixing memory leak in EditableTextState" (flutter/flu…
ee87f04 
…tter#133804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Renzo-Olivares @fluttergithubbot