Skip to content

give --task-args option in test_runner a help description #133791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Aug 31, 2023
Merged

give --task-args option in test_runner a help description #133791

auto-submit merged 2 commits into from
Aug 31, 2023

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Aug 31, 2023 •
edited
Loading

Fixes #133790

Provides help text for the --task-args option of the test_runner devicelab command. The current help text is just copypasta from another option's help text

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 31, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@andrewkolos andrewkolos changed the title give --task-args option in flutter test a help description give --task-args option in test_runner a help description Aug 31, 2023
@Hixie
Copy link
Contributor

Hixie commented Aug 31, 2023

test-exempt: help for internal tool

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023
@auto-submit auto-submit bot merged commit c263c56 into flutter:master Aug 31, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
8fe943d 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
ab882e4 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
075af34 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
272bada 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
c13d004 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
bfbf3e7 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
8407e56 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
992b9a4 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
1b53836 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
e02c083 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
2d4fa07 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
383c326 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
3fb28aa 
…lutter/flutter#133791)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
8331227 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
9e37aa4 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
c5f776d 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
b0b6235 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
d07ddb3 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
fbd0ee6 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
e8dfbe4 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
71cbfb6 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
23a9f5b 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
b2145c7 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
02bcd64 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
aaf4941 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
aa6851f 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
f84b3fa 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
7435fd8 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
310e0fa 
…lutter/flutter#133791)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
c263c56 give --task-args option in test_runner a help description (f…
fc49e42 
…lutter/flutter#133791)
@andrewkolos andrewkolos deleted the fix-typo branch April 29, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--task-args option in devicelab command test_runner has inaccurate help text

3 participants

@andrewkolos @Hixie @CaseyHillers