Skip to content

fix install checks in flavors devicelab tests #133719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Sep 1, 2023
Merged

fix install checks in flavors devicelab tests #133719

auto-submit merged 4 commits into from
Sep 1, 2023

Conversation

@andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Aug 30, 2023 •
edited
Loading

Fixes #133713

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@andrewkolos andrewkolos added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 30, 2023
@andrewkolos andrewkolos mentioned this pull request Aug 31, 2023
Closed
8 tasks
@andrewkolos
Copy link
Contributor Author

andrewkolos commented Sep 1, 2023

I've tested this with Linux_android flavors_test and Mac_ios flavors_test_ios, but I couldn't run Windows_android flavors_test since we have no eligible bots in the try pool to run it. It's probably safe though; because, as far as this change is concerned, the tests are identical on Windows and Linux hosts.

@andrewkolos andrewkolos marked this pull request as ready for review September 1, 2023 16:04
christopherfujino
christopherfujino reviewed Sep 1, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Sep 1, 2023
View reviewed changes
dev/devicelab/bin/tasks/flavors_test.dart Outdated
Copy link
Contributor

@christopherfujino christopherfujino Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#if-you-have-a-newline-after-some-opening-punctuation-match-it-on-the-closing-punctuation

On the second line (18) here, the indent should just be 2 more than line 17, and then the start of the callback should be on a new line (19) indented the same as line 18, and then the rest of the callback body indented +2.

Copy link
Contributor Author

@andrewkolos andrewkolos Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. It should be fixed now. Fun fact: I got the original formatting from dart format

christopherfujino
christopherfujino reviewed Sep 1, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Sep 1, 2023
View reviewed changes
christopherfujino
christopherfujino reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have led builds where these pass?

@andrewkolos
Copy link
Contributor Author

andrewkolos commented Sep 1, 2023

do you have led builds where these pass?

Oh yeah, forgot to add those. Linux_android flavors_test. Mac_ios flavors_test_ios. I don't have anything for Windows_android flavors_test since we don't have try bots for that, but it should be functionality identical to Linux_android flavors_test as far as this change is concerned.

christopherfujino
christopherfujino approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this yak shave

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 1, 2023

auto label is removed for flutter/flutter/133719, due to - The status or check suite Linux web_tests_0 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@andrewkolos andrewkolos force-pushed the fix-flavors_test-install-checks branch from ebea153 to 997b93e Compare September 1, 2023 19:28
@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit auto-submit bot merged commit a66eae1 into flutter:master Sep 1, 2023
vashworth added a commit that referenced this pull request Sep 1, 2023
@vashworth
Revert "fix install checks in flavors devicelab tests (#133719)"
f19be4f 
This reverts commit a66eae1.
@vashworth vashworth mentioned this pull request Sep 1, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Sep 1, 2023
@vashworth
Revert "fix install checks in flavors devicelab tests" (#133894)
5649161 
Reverts #133719

`Windows_android flavors_test_win` failed twice in a row in the tree
@vashworth
Copy link
Contributor

vashworth commented Sep 1, 2023

@andrewkolos @christopherfujino I reverted this PR, it was failing Windows_android flavors_test_win in the tree

https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20flavors_test_win/7438/overview

@andrewkolos andrewkolos mentioned this pull request Sep 1, 2023
Closed
@christopherfujino
Copy link
Contributor

christopherfujino commented Sep 2, 2023

@andrewkolos @christopherfujino I reverted this PR, it was failing Windows_android flavors_test_win in the tree

https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20flavors_test_win/7438/overview

Thanks!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
add9d9c 
…r#133719)
@andrewkolos andrewkolos mentioned this pull request Sep 5, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
auto-submit bot pushed a commit that referenced this pull request Sep 5, 2023
@andrewkolos
[Reland] Fix flavors test install checks (#134060)
c05dc3e 
Reland of #133719. Updates [the string comparison in flavor_test.dart](https://github.com/flutter/flutter/pull/134060/files#diff-53383b32b975bfed6875306dfb98911cad077a5251ca0591c5b0e125fb4a0f05R39) to use `path.join` to build the path string so that the generated path is correct for both Linux and Windows hosts.

Fixes #133713

I've tested this on a Windows host targeting a physical Android device.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
b799a6e 
…r#133719)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
ace8bc6 
…r#133719)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
5659602 
…r#133719)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
9c2028b 
…r#133719)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
bad7e9c 
…r#133719)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
75d4ce0 
…r#133719)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
462a562 
…r#133719)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
5f1e43e 
…r#133719)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
6fe7ffa 
…r#133719)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
53f8a09 
…r#133719)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
1703f27 
…r#133719)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
aba2b6f 
…r#133719)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
6dcbae4 
…r#133719)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
20e7bdc 
…r#133719)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
a66eae1 fix install checks in flavors devicelab tests (flutter/flutte…
0e81559 
…r#133719)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

devicelab test for flutter install with an invalid --flavor cannot fail

3 participants

@andrewkolos @vashworth @christopherfujino