Skip to content

Removes ios universal link vmservices and let xcodeproject to dump js… #133709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Aug 31, 2023
Merged

Removes ios universal link vmservices and let xcodeproject to dump js… #133709

auto-submit merged 3 commits into from
Aug 31, 2023

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Aug 30, 2023

…on file

The deeplink validation tool will become an static app so it can't no longer access vm services.

The goal will be then to turn them into flutter analyze command similar to flutter analyze --android --[options] that static app can use on.

This pr only removes vm services and turn the api to dump a output file instead of printing everything to stdout.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai requested a review from vashworth August 30, 2023 23:01
@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 30, 2023
vashworth
vashworth reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that your new method outputUniversalLinkSettings is not called anywhere (other than tests). Is that intentional?

packages/flutter_tools/test/general.shard/project_test.dart
final File outputFile = fs.file(outputFilePath);
final Map<String, Object?> json = jsonDecode(outputFile.readAsStringSync()) as Map<String, Object?>;
expect(json['teamIdentifier'], 'ABC');
expect(json['bundleIdentifier'], 'io.flutter.someProject');
Copy link
Contributor

@vashworth vashworth Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a expectation for associatedDomains here? I believe you'd expect it to be empty list?

vashworth
vashworth reviewed Aug 31, 2023
View reviewed changes
packages/flutter_tools/lib/src/xcode_project.dart Outdated
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'dart:convert';
Copy link
Contributor

@vashworth vashworth Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error from failing tests:

lib/src/xcode_project.dart imports 'dart:convert'; import 'lib/src/convert.dart' instead

@chunhtai
Copy link
Contributor Author

chunhtai commented Aug 31, 2023

It seems that your new method outputUniversalLinkSettings is not called anywhere (other than tests). Is that intentional?

There will be another pr that wire up outputUniversalLinkSettings to flutter analyze command

@chunhtai chunhtai requested a review from vashworth August 31, 2023 16:58
vashworth
vashworth requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you also need to update integration.shard/vmservice_integration_test.dart

vashworth
vashworth approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023
@auto-submit auto-submit bot merged commit 0b3b8cd into flutter:master Aug 31, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
2e89e55 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
e044123 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
b472790 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
eb2764b 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
a1779bf 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
b8861db 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
afe6414 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
500b433 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
8a3b107 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
f39b44d 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
6795fec 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
70c5387 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
20f50ff 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
c0e6a3c 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
bced818 
… dump js… (flutter/flutter#133709)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
e5ec180 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
92edfbe 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
99a4d9a 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
23e1b77 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
8adbce4 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
69c66ee 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
2e917f3 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
d1bbdff 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
7839748 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
aba118d 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
7de88ca 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
4b1cfe9 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
895a2c9 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
2f7e4e9 
… dump js… (flutter/flutter#133709)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
0b3b8cd Removes ios universal link vmservices and let xcodeproject to…
fdeb16e 
… dump js… (flutter/flutter#133709)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth vashworth approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chunhtai @vashworth