Skip to content

Fix clipBehavior ignored in Scrollable of SingleChildScrollView #133696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Aug 31, 2023
Merged

Fix clipBehavior ignored in Scrollable of SingleChildScrollView #133696

auto-submit merged 5 commits into from
Aug 31, 2023

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 30, 2023

Fixes #133330

The clipBehavior was not passed to the underlying Scrollable, which informs things like the clip on the StretchingOverscrollIndicator.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Aug 30, 2023
Renzo-Olivares
Renzo-Olivares approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2023
@Piinks Piinks removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2023
@github-actions github-actions bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Aug 30, 2023
@Piinks
Copy link
Contributor Author

Piinks commented Aug 30, 2023

Oh shoot I pushed changes from another branch by accident

@Piinks Piinks added autosubmit Merge PR when tree becomes green via auto submit App and removed d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Aug 31, 2023
@auto-submit auto-submit bot merged commit cf051e7 into flutter:master Aug 31, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
b376210 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
0456a30 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
7f48ef7 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
1f0d26d 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
767254d 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
e60f1fc 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
ca0cf60 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
6d9b7ad 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
f32bb03 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
0b2b4df 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
4a82dd4 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
9e6b484 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
96605e8 
…ew (flutter/flutter#133696)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
554afbd 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
fa2e866 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
5ad1403 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
a4c3b71 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
6b915f4 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
336f933 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
8c72afe 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
139072e 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
be78905 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
51d4932 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
32b2be7 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
a22f8c9 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
85b7743 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
676268d 
…ew (flutter/flutter#133696)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
cf051e7 Fix clipBehavior ignored in Scrollable of SingleChildScrollVi…
2bb64b9 
…ew (flutter/flutter#133696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clip.none ignored during overscroll on Android

2 participants

@Piinks @Renzo-Olivares